[TIMOB-24000] CLI: Module build should error if the apiversion in manifest does not match the SDKs apiversion
| GitHub Issue | n/a |
|---|
| Type | Improvement |
|---|
| Priority | Medium |
|---|
| Status | Closed |
|---|
| Resolution | Fixed |
|---|
| Resolution Date | 2017-11-13T21:59:48.000+0000 |
|---|
| Affected Version/s | Release 6.0.0, Release 5.5.0 |
|---|
| Fix Version/s | Release 7.0.0 |
|---|
| Components | Tooling |
|---|
| Labels | cb-tooling, qe-6.0.0 |
|---|
| Reporter | Ewan Harris |
|---|
| Assignee | Feon Sua Xin Miao |
|---|
| Created | 2016-10-07T10:53:25.000+0000 |
|---|
| Updated | 2017-11-27T10:07:58.000+0000 |
|---|
Description
Description
When building a module if the apiversion in the manifest does not match the platforms apiversion in the SDK then the module build should fail. Currently if the apiversion is different then the build will take place and the user will produce a module that is not considered to be valid for the SDK it is build against. For example.
* Developer rebuilds Android module for 6.0.0, forgetting to bump apiversion
* User of module downloads the new module, and tries to build
* Build fails as the apiversion does not match
Steps to reproduce
Create a module using ti create -p android --type module --name mymodule --id com.my.mod
Change the maifest apiversion to 2
Build for Android using 6.X SDK
Actual result
Build takes place despite the differing apiversions between SDK and module
Expected result
Build should fail as the apiversions are different
Comments
JSON Source
[~eharris] Do you think we can make this into 6.2.0 or should it be moved to 7.0.0? Trying to slim down the open tickets a bit.
I see no urgent need for this to be in 6.2.0, it should probably be done for 7.0.0 to prevent any errors when people rebuild modules agains
PR: https://github.com/appcelerator/titanium_mobile/pull/9563 Note:
apiversionandminsdkprobably could be the product of the build, they should be injected into the build module's manifest when we have a record of the exact version number that's the min for a given apiversion.Passed FR. Merged. Changes seen in SDK 7.0.0.v20171114202841.