Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-24041] Include module hooks in packaged zip

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2016-12-01T20:45:29.000+0000
Affected Version/sRelease 6.0.0, Release 5.5.1
Fix Version/sRelease 6.0.1
ComponentsAndroid, CLI, iOS
Labelshook, zip
ReporterHans Knöchel
AssigneeChris Barber
Created2016-10-15T16:58:24.000+0000
Updated2017-09-25T18:04:52.000+0000

Description

We are able to place a hooks folder inside our native modules and place build-hooks in there that are picked up by the build system. Currently, it already works, but the directory is not copied over to the zip file after packaging it. We should change that.

Comments

  1. Hans Knöchel 2016-10-15

    PR: https://github.com/appcelerator/titanium_mobile/pull/8519
  2. Chris Barber 2016-10-17

    When I tested this, Android modules failed to build and iOS modules didn't include the hooks.
  3. Chris Barber 2016-11-17

    TiSDK master PR: https://github.com/appcelerator/titanium_mobile/pull/8620 TiSDK 6_0_X PR: https://github.com/appcelerator/titanium_mobile/pull/8621
  4. Lokesh Choudhary 2016-11-30

    [~cbarber], How can I test this ? Any test steps ?
  5. Lokesh Choudhary 2016-12-01

    Verified the fix for Android & IOS. The hooks folder gets included in the packaged module. Closing. Appc Studio : 4.8.1.201611291132 SDK Version : 6.1.0.v20161201064221, 6.0.1.v20161130023500 Mac OS Version : 10.12 Xcode Version : Xcode 8.1 Build version 8B62 Appc CLI AND Appc NPM : {"NPM":"4.2.9-1","CLI":"6.1.0-302"} Ti CLI : 5.0.11 Alloy : 1.9.4 Node : v4.6.0
  6. Lokesh Choudhary 2016-12-01

    Reopening to add SDK version.

JSON Source