Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-24048] Android: Window transition animations are not working as expected

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2016-11-01T14:56:36.000+0000
Affected Version/sRelease 5.4.0, Release 5.5.0, Release 5.5.1
Fix Version/sRelease 6.1.0
ComponentsAndroid
Labelsn/a
Reporter Ricardo Ramirez
AssigneeGary Mathews
Created2016-10-18T18:17:31.000+0000
Updated2016-11-21T23:48:16.000+0000

Description

Issue Description

The activityExitAnimation and activityEnterAnimations parameters are not being honored on Ti.Window's close method. This causes windows to not animate when they close. Customer is using custom animations, but that should not matter. They are properly defined in app/platform/android/res/anim. The code to really look at is in app/controllers/newWindow.js:
$.win.open({
activityEnterAnimation: Ti.App.Android.R.anim.slide_in,
activityExitAnimation: Ti.App.Android.R.anim.still
});

function close(){
$.win.close({
activityEnterAnimation: Ti.App.Android.R.anim.still,
activityExitAnimation: Ti.App.Android.R.anim.slide_out
});
}
The open call animates as expected. The close call does not animate as expected on TiSDK versions newer than 5.3.1.GA.

Steps to reproduce:

1) Build the test case to an Android device using TiSDK 5.4.0.GA or higher (with highest version currently being 5.5.1.GA) 2) Press the "OPEN NEW WINDOW" button 3) Observe the new window slide in from the left 4) Press the "CLOSE ME!" button on the new window 5) Observe the new window closing with no animation

Expected behavior:

1) Build the test case to an Android device using TiSDK 5.3.1.GA 2) Press the "OPEN NEW WINDOW" button 3) Observe the new window slide in from the left 4) Press the "CLOSE ME!" button on the new window 5) Observe the new window slide out to the right

Attachments

FileDateSize
window-animation-test.zip2016-10-18T18:17:06.000+000010480950

Comments

  1. Gary Mathews 2016-10-25

    master: https://github.com/appcelerator/titanium_mobile/pull/8546
  2. Samir Mohammed 2016-11-21

    Verified fixed using the test code provided, was able to see the transition affect sliding out to the right on SDK version 6.1.0.v20161121091240 when pressing "Close Me!". Was also able to see the transition effect sliding out to the left when pressing "Open new window". *Environment*
       Appcelerator Command-Line Interface, version 6.0.0
       Android 7.0 (Google Nexus 6P)
       Operating System Name: Mac OS X El Capitan
       Operating System Version: 10.11.6
       Node.js Version: 4.6.0
       npm: 4.2.8
       Titanium CLI Version: 5.0.10
       Titanium SDK Version: 6.1.0.v20161121091240
       Xcode: 8.0
       Appcelerator Studio: 4.8.0.201611121409
       

JSON Source