[TIMOB-24126] Windows: Adding a searchbar to a tableview or listview search property should also add it to the window

GitHub Issue	n/a
Type	Improvement
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2017-01-28T04:33:35.000+0000
Affected Version/s	Release 6.0.0
Fix Version/s	Release 6.1.0
Components	Windows
Labels	eng-priority, parity, qe-6.0.0
Reporter	Ewan Harris
Assignee	Kota Iguchi
Created	2016-11-09T14:53:33.000+0000
Updated	2017-02-06T18:46:51.000+0000

Description

When setting a searchbar to the search property of a tableview or a listview Android and iOS will add the searchbar to the view for a user.

var _window = Ti.UI.createWindow();
var searchBar = Ti.UI.createSearchBar({
});

var tableView = Ti.UI.createTableView({
    search: searchBar,
    data: [{title: 'Test1'}, {title: 'Test2'}]
});
_window.add(tableView);
_window.open();

Steps to reproduce

Add the above code to an existing app.js

Build for Windows platform

Actual result

Searchview is not added to the view unless a developer explicitly does so

Expected result

Searchview should be added to the view when added to a tableview/listview

Attachments

File	Date	Size
6.1.0.v20170202120400.PNG	2017-02-06T18:18:10.000+0000	29240

Comments

Gary Mathews 2017-01-26

master: https://github.com/appcelerator/titanium_mobile_windows/pull/936
Abir Mukherjee 2017-01-27

[~kota] Which fixVersion is this going in? The field currently has "None".
Kota Iguchi 2017-01-27

This should go to 6.1.0. Updated.

Samir Mohammed 2017-02-06

Verified fixed with the code provided above, was able to see the search bar and use it to search for items in the tableview. !6.1.0.v20170202120400.PNG|thumbnail! *Environment*

   Phone : Lumia 640 LTE (RM-1073)
   Operating System:
   Name                        = Microsoft Windows 10 Pro
   Version                     = 10.0.14393
   Architecture                = 32bit
   CPUs                      = 4
   Memory                      = 17034395648
    
   Node.js:
   Node.js Version             = 4.6.0 
   npm Version                 = 2.15.9
    
   Titanium SDK:
   SDK Version                 =  6.1.0.v20170202120400

JSON Source