[TIMOB-24165] Android: Unable remove action bar using custom theme when the window background color is transparent.
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | None |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2017-03-28T23:12:30.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 6.0.4 |
Components | Android |
Labels | primary, qe-6.1.0 |
Reporter | Shuo Liang |
Assignee | Gary Mathews |
Created | 2016-11-23T01:32:21.000+0000 |
Updated | 2017-03-29T18:06:48.000+0000 |
Description
Problem
Customer facing following problem Using custom theme for android to remove action bar. It is working fine in all the cases except when the window background color is transparent.Reproduce
Attached test caseAttachments
File | Date | Size |
---|---|---|
custom_theme.xml | 2016-11-23T01:31:38.000+0000 | 408 |
test_without.jpg | 2017-03-28T12:00:43.000+0000 | 287463 |
test.jpg | 2017-03-28T11:46:06.000+0000 | 111665 |
tiapp.xml | 2016-11-23T01:32:16.000+0000 | 2187 |
TIMOB-24165.zip | 2017-03-28T11:55:06.000+0000 | 2624 |
transparentWin.tss | 2016-11-23T01:31:02.000+0000 | 76 |
transparentWin.xml | 2016-11-23T01:30:48.000+0000 | 181 |
Verified as fixed the action bar can now be removed using a custom theme when the background is transparent. Tested on: {noformat} macOS Sierra 10.12.1 Nexus 5X(6.0.1) Nexus 6p (7.0) android emulator (4.4.2, 6.0) Studio: 4.8.0.201611121409 Ti SDK: 6.1.0.v20161202081834 Appc NPM: 4.2.8 App CLI: 6.1.0-302 Node v4.4.7 {noformat} *Closing Ticket.*
For the records, the PR on master was: https://github.com/appcelerator/titanium_mobile/pull/8639
Reopening for backport
6_0_X: https://github.com/appcelerator/titanium_mobile/pull/8911
Check backport PR for comment.
[~lchoudhary] I've tested using
6.0.4.v20170324115015
with the [changes](https://github.com/appcelerator/titanium_mobile/pull/8911/files) applied and it seems to work fine. !test.jpg|thumbnail! For comparison, here's a screenshot without the fix applied. !test_without.jpg|thumbnail! Here's the test case I'm using: [^TIMOB-24165.zip]Verified the fix with locally built 6.0.4 for the modified PR https://github.com/appcelerator/titanium_mobile/pull/8911. Waiting for build from jenkins to close the ticket.
Verified the fix with 6.0.4.v20170328161159. Closing.