[TIMOB-2417] Android: Facebook - publish stream - long lag on button press
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Medium |
| Status | Closed |
| Resolution | Invalid |
| Resolution Date | 2011-04-15T03:19:12.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 1.5.0 M04 |
| Components | Android |
| Labels | android, defect, facebook, regression |
| Reporter | Thomas Huelbert |
| Assignee | Don Thorp |
| Created | 2011-04-15T03:19:10.000+0000 |
| Updated | 2017-03-02T19:28:03.000+0000 |
Description
1.5.0.91838a G2 (2.2), Droid1 (2.2) sim 2.1
1.Facebook > log in
2.Facebook > publish stream > tap publish stream button
Results: the button takes the press, but no action occurs for 3 seconds or so, looking like the app is dead. the behavior at this point is intermittant, it did work most of the time, but occasionally locked up on the droid1
Triage in M04, may not be problematic enough to warrant 1.5.0.
I actually gave this a closer look than I probably should have (time-wise), given that we definitely won't change this sdk at all for 1.5 (unless something simply doesn't work.)
The delay occurs in FBDialog.loadUrl. (You can see the https://skitch.com/billdawson/rn48m/terminal-adb-99x28">logcat with timing info here. That code makes a complete, invisible POST request before even popping up a webview -- I guess it does it in order to set a cookie (authorization) in the Cookie Manager before then showing the webview. After that's finished, it then finally shows the webview and navigates to the special facebook page that lets you make the stream entry.
This code all comes from a third-party SDK -- it's very brittle and we're replacing it hopefully soon via #2254.
What's the right approach ticket-wise? I would close this completely ("invalid" or something) rather than push it off to another milestone, because I don't want to touch this third-party SDK -- i want to replace it. So in a sense I feel like we'll never actually try to make this code better/faster.
Assigning to Thomas for his opinion on disposition.
agree with Bill and marking as invalid. would be nice to have "NOB" (not our bug) for these issues. in the new bug base :)
Closed as invalid.