[TIMOB-24189] Windows: Add support for Visual Studio 2017
GitHub Issue | n/a |
---|---|
Type | New Feature |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2017-08-25T13:01:25.000+0000 |
Affected Version/s | Release 6.1.0 |
Fix Version/s | windowslib 0.4.29, Release 6.2.0 |
Components | Windows |
Labels | n/a |
Reporter | Ewan Harris |
Assignee | Kota Iguchi |
Created | 2016-12-02T00:17:37.000+0000 |
Updated | 2017-08-25T14:05:35.000+0000 |
Description
Description
windowslib does not detect VS 2017 RC, this is because Microsoft has made VS more isolated so that multiple editions can coexist and now stores the key we look for (\VisualStudio\C:\Users\ewan\AppData\Local\Microsoft\VisualStudio\15.0_d5badba5
, to inspect this registry:
Spent some time reading about the changes in VS 2017 and found this sample for setup detection https://github.com/Microsoft/vs-setup-samples One interesting note
This change to the Visual Studio platform requires new ways of discovering Visual Studio where simple registry detection does not provide the flexibility required in many scenarios.
Pushing this in current sprint because VS 2017 will be released soon.
Pushed https://github.com/appcelerator/titanium_mobile_windows/pull/959 But still failing to make
msbuild
work. I suspectmsbuild
has issues because it fails even when you execute msbuild manually against default UWP application project (that Visual Studio creates via "New Project -> Windows Universal C# app").So what's interesting is that when you open .sln file manually from Visual Studio 2017, you are able to build it. So maybe Visual Studio does something more than executing msbuild behind the scenes. maybe setting up configurations, or giving additional parameters to msbuild...? Pushing this so that hopefully we could get something from community to this PR.
https://github.com/appcelerator/titanium_mobile_windows/pull/959 https://github.com/appcelerator/windowslib/pull/66
https://github.com/appcelerator/titanium_mobile/pull/8893
Merged. https://github.com/appcelerator/titanium_mobile_windows/pull/1074
Verified changes in 6.2.0.v20170821203442