[TIMOB-24394] iOS: "Unable to locate iOS Package Application tool" using Xcode 8.3 for device builds

GitHub Issue	n/a
Type	Bug
Priority	None
Status	Closed
Resolution	Fixed
Resolution Date	2017-02-13T22:20:40.000+0000
Affected Version/s	n/a
Fix Version/s	Release 6.0.2
Components	iOS
Labels	ios, xcode8.3
Reporter	Hans Knöchel
Assignee	Chris Barber
Created	2017-02-09T14:03:52.000+0000
Updated	2017-02-13T22:38:58.000+0000

Description

When building for device using Xcode 8.3 Beta, the following warning is logged before iTunes is opened (and the app shows up there):

[TRACE] ** BUILD SUCCEEDED **
[INFO]  Finished building the application in 1m 23s 176ms
[WARN]  Unable to locate iOS Package Application tool
[INFO]  Installing application into iTunes
[INFO]  Initiating iTunes sync

To reproduce: 1. Create a new project: appc new -p ios 2. Run the project on the device, but don't attach a device: appc run -p ios -T device

Comments

Chris Barber 2017-02-09

Good catch. I have no idea why device builds call PackageApplication, but that's how it's always been: https://github.com/appcelerator/titanium_mobile/blob/master/support/iphone/builder.py#L1539. I'll have to research it and see if we still need this.
Hans Knöchel 2017-02-09

I'd actually strip out the [whole block](https://github.com/appcelerator/titanium_mobile/blob/master/iphone/cli/hooks/install.js#L27-L41). I mean, we package the application waaay earlier, so the install hook should really only install it, nothing else. And as the correct .ipa shows up on iTunes, I don't see any side-effects. But you'll have a better insight into this :-).
Chris Barber 2017-02-09

From my testing, removing the call to PackageApplication has no side effects, so adios! Titanium SDK master PR: https://github.com/appcelerator/titanium_mobile/pull/8824 Titanium SDK 6_0_X PR: https://github.com/appcelerator/titanium_mobile/pull/8825
Eric Wieber 2017-02-13

FR Passed. Tested using: MacOS 10.12 (16A323) Studio 4.8.1.201701192045 Ti SDK 6.0.2 Appc NPM 4.2.8 Appc CLI 6.1.0 Alloy 1.9.5 Xcode 8.3b2 and 8.2.1 (8C1002) Built multiple projects for device and did not witness the error/warning. Tested using Xcode 8.3 and 8.2.1, with Alloy and Classic apps.
Eric Wieber 2017-02-13

Verified in SDK builds: 6.0.2.v20170213142042 6.1.0.v20170213134957

JSON Source