[TIMOB-24590] iOS: require() file content leaks
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Duplicate |
| Resolution Date | 2017-04-24T17:12:18.000+0000 |
| Affected Version/s | Release 6.0.3 |
| Fix Version/s | n/a |
| Components | n/a |
| Labels | n/a |
| Reporter | Chris Bowley |
| Assignee | Hans Knöchel |
| Created | 2017-04-18T15:24:14.000+0000 |
| Updated | 2017-04-24T17:39:04.000+0000 |
Description
On iOS, contents of files loaded through require() are leaked under 6.0.3.GA due to missing (auto)release statement: https://github.com/appcelerator/titanium_mobile/blob/6_0_X/iphone/Classes/KrollBridge.m#L923
This is already fixed with commit https://github.com/appcelerator/titanium_mobile/commit/46e83b20895f110fbf0b6adcf93edd84968c4ec9 and on master: https://github.com/appcelerator/titanium_mobile/blob/master/iphone/Classes/KrollBridge.m#L923.
Interesting interesting. We need to decide if we just take the specific leak-fix or the whole 6.1.0 PR from TIMOB-23542. I'm curious because the ticket is resolved but not closed so far, and it includes a hell lot of sensitive touches. I'd say we take the whole PR, but then we need to spend some time checking the above ticket. Let me prepare a backport.
Backport-PR: https://github.com/appcelerator/titanium_mobile/pull/8973
Marking as Duplicate of TIMOB-23542 to manage the test-cases and fix-version there.
Agree that ticket is Duplicate of an existing ticket as commented by Hans above.