[TIMOB-24690] Fork correct sdk broken due to missing tisdk3fixes hook
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2017-05-12T21:44:19.000+0000 |
Affected Version/s | n/a |
Fix Version/s | titanium 5.0.14 |
Components | CLI |
Labels | n/a |
Reporter | Chris Barber |
Assignee | Chris Barber |
Created | 2017-05-12T21:15:26.000+0000 |
Updated | 2018-08-06T17:49:13.000+0000 |
Description
Turns out we need the
tisdk3fixes.js
hook that was recently removed.
We need this file because it monkey patches the correct ti sdk validation function which is fired from the --platform
callback function. If the tiapp.xml <sdk-version>
doesn't match the selected SDK, it forks the correct build command, then throws a GracefulShutdown exception which needs to be caught correctly and that's what the monkey patch does, apparently.
titanium master PR https://github.com/appcelerator/titanium/pull/268
Cleaning up older fixed issues. If this issue should not have been closed as fixed, please reopen.