Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-24693] LiveView: Incorrect argument checked for custom IP

GitHub Issuen/a
TypeBug
PriorityNone
StatusClosed
ResolutionFixed
Resolution Date2017-05-15T16:27:06.000+0000
Affected Version/sn/a
Fix Version/sRelease 6.1.0
ComponentsLiveView
Labelsn/a
ReporterEwan Harris
AssigneeEwan Harris
Created2017-05-15T12:11:34.000+0000
Updated2017-05-18T18:02:14.000+0000

Description

Description

When passing in a custom IP for liveview to use the command line arg is --liveview-ip, liveview checks for liveview-host https://github.com/appcelerator/liveview/blob/4de3f39330fcd6de5ca90b406f4b94c4feaf32d1/hook/lvhook.js#L129

Steps to reproduce

Build an app with --liveview --liveview-ip 123.4.5.6

Check the logs

Actual

App starts and errors out that it cant access an ip that is not 123.4.5.6

Expected

App should start and error out that it cant access 123.4.5.6

Comments

  1. Ewan Harris 2017-05-15

    PR: https://github.com/appcelerator/liveview/pull/100
  2. Ewan Harris 2017-05-15

    Studio PR: https://github.com/appcelerator/titanium_studio/pull/906
  3. Abir Mukherjee 2017-05-18

    Node Version: 6.10.1 NPM Version: 3.10.10 Mac OS: 10.12.4 Appc CLI: 6.2.2-master.7 Appc CLI NPM: 4.2.9 Titanium SDK version: 6.1.0.v20170517143931 Xcode 8.3.2 Android Emulator 6.0.1 [~eharris] I followed the steps to reproduce, and I did not get errors with the latest SDK build. In the "expected" you have that it should error out. Is that correct? I did not get any errors. The SDK version I used which doe have the fix is 6.1.0.v20170517143931.
  4. Abir Mukherjee 2017-05-18

    I validated the fix with the environment mentioned in my above comment. For reference, I needed to build an app in Studio with LiveView enabled so that path.hooks is updated correctly. Closing ticket as I was able to validate the fix.

JSON Source