[TIMOB-24712] Android: SDK 6.1.0.RC doesnt honor custom_theme.xml colorPrimary setting
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2017-05-24T22:33:20.000+0000 |
Affected Version/s | Release 6.1.0 |
Fix Version/s | Release 6.1.0 |
Components | Android |
Labels | SDK6.1.0.RC |
Reporter | greg |
Assignee | Joshua Quick |
Created | 2017-05-21T20:52:49.000+0000 |
Updated | 2017-07-26T15:25:57.000+0000 |
Description
I have the following custom scheme.
<?xml version="1.0" encoding="utf-8"?>
<resources>
<style name="tracker" parent="@style/Theme.AppCompat">
<item name="colorPrimary">#0054a6</item>
<item name="colorAccent">#FFFFFF</item>
<item name="android:statusBarColor">#004486</item>
<item name="android:navigationBarColor">#004486</item>
</style>
<style name="tracker.NoActionBar" parent="@style/Theme.AppCompat">
<!-- AppCompat Compatibility -->
<item name="windowActionBar">false</item>
<item name="windowNoTitle">true</item>
</style>
</resources>
On compiling under 6.1.0.RC I find that the colorPrimary (#0054a6) is no longer a nice blue, but an ugly gray. Go back to the previous version and it all works as expected.
You mean 6.1.0.RC, not 6.0.1.RC right?
Oops, typo. Yes its the new 6.1.0.RC
Confirmed bug. However, we were only able to reproduce this issue in a window using a TabGroup.
PR (6.1.X): https://github.com/appcelerator/titanium_mobile/pull/9074
PR (master): https://github.com/appcelerator/titanium_mobile/pull/9081
FR for master & backport PR done.
Verified the fix. The settings in the custom theme are honored as expected. Closing. Studio Ver: 4.9.0.201705180402 SDK Ver: 6.2.0.v20170525141419, 6.1.0.v20170524162819 OS Ver: 10.12.3 Xcode Ver: Xcode 8.3.2 Appc NPM: 4.2.9 Appc CLI: 6.2.2 Ti CLI Ver: 5.0.14 Alloy Ver: 1.9.11 Node Ver: 6.10.1 Java Ver: 1.8.0_101 Devices: ⇨ google Nexus 6 --- Android 6.0.1, Samsung Galaxy S4 --- Android 4.4.4
I was able to reproduce the bug on 6.1.1.GA
[~bduyng@gmail.com] Can you provide an example of the custom theme usage in the application?