[TIMOB-24779] CLI: Error message for too old build-tools is confusing

GitHub Issue	n/a
Type	Bug
Priority	None
Status	Closed
Resolution	Duplicate
Resolution Date	2018-08-29T18:39:40.000+0000
Affected Version/s	Release 6.1.0
Fix Version/s	n/a
Components	Android, CLI
Labels	n/a
Reporter	Ewan Harris
Assignee	Unknown
Created	2017-06-06T09:56:11.000+0000
Updated	2018-08-29T18:39:40.000+0000

Description

When building with a Android SDK Build-tools version that is too old, the error message is confusing (at least to me). I would expect a warning that my version is too old, not that I have tools missing.

[ERROR] Missing required Android SDK tools: zipalign, aapt, aidl, dx
[ERROR]
[ERROR] The Android SDK located at /Users/eharris/Library/Android/sdk has incomplete or out-of-date packages.
[ERROR]
[ERROR] Current installed Android SDK tools:
[ERROR]   Android SDK Tools:          25.2.5
[ERROR]   Android SDK Platform Tools: 25.0.6
[ERROR]   Android SDK Build Tools:    not installed
[ERROR]
[ERROR] Make sure you have the latest Android SDK Tools, Platform Tools, and Build Tools installed.
[ERROR]
[ERROR] You can also specify the exact location of these required tools by running:
[ERROR]   ti config android.executables.zipalign "/path/to/android-sdk/zipalign"
[ERROR]   ti config android.executables.aapt "/path/to/android-sdk/aapt"
[ERROR]   ti config android.executables.aidl "/path/to/android-sdk/aidl"
[ERROR]   ti config android.executables.dx "/path/to/android-sdk/dx"
[ERROR]
[ERROR] If you need to, run "titanium setup android" to reconfigure the Titanium Android settings.

Steps to reproduce

I ran into this while fixing TIMOB-24778, if you test this before that fix is available edit the package.json file under <SDK>/android/ to match "android build tools": ">=23 <=25.x",

Install Android SDK Build-tools@22.0.1

Build a project with appc run -p android -T device --build-only

Actual

Error message shown is confusing as it says tools are not installed, when they are but are just unsupported

Expect

Error message should match the reality

Comments

Joshua Quick 2018-08-28

[~eharris], I remember you changed the error messaging via another ticket. Should we close this one?

Ewan Harris 2018-08-29

Yeah I'm happy to close this, when using an unsupported set of tools on 7.5.0 it now logs the below which to me is a bit clearer.

     ✕  Android Build Tools 27.0.2 are not supported by Titanium
        Current installed Android SDK tools:
          Android SDK Tools:          26.1.1  (Supported: <=26.x)
          Android SDK Platform Tools: 28.0.0  (Supported: 27.x)
          Android SDK Build Tools:    27.0.2  (Supported: >=28.x <=29.x)
   
        Make sure you have the latest Android SDK Tools, Platform Tools, and Build Tools installed.

Please note that I changed the supported versions to test this

Ewan Harris 2018-08-29

Closing as a dupe of TIMOB-26180 as that cleared up the messaging

JSON Source