[TIMOB-24805] iOS: Support large window-titles

GitHub Issue	n/a
Type	New Feature
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2017-10-31T16:58:57.000+0000
Affected Version/s	n/a
Fix Version/s	Release 6.3.0
Components	iOS
Labels	ios11
Reporter	Hans Knöchel
Assignee	Hans Knöchel
Created	2017-06-10T12:33:27.000+0000
Updated	2017-11-14T23:22:03.000+0000

Description

iOS 11 offers a new way of setting a large window-title like nearly all system apps (Music, Settings, Phone, ..) do. See [this StackOverflow post](https://stackoverflow.com/questions/44409173/use-the-increased-navigation-bar-title-in-ios-11) for more infos. Proposed new API's: * largeTitleEnabled: \[true/false] * largeTitleDisplayMode: \[Ti.UI.iOS.LARGE_TITLE_DISPLAY_MODE_*] Also, the existing titleAttributes should be applied to these as well.

Comments

Hans Knöchel 2017-06-10

PR: https://github.com/appcelerator/titanium_mobile/pull/9136 Test-Case:

   var win = Ti.UI.createWindow({
       backgroundColor: '#fff',
       title: 'Titanium rocks!',
       
       // Also applied for large titles
       titleAttributes: {
         color: 'red'
       },
       
       // NEW in iOS 11!
       largeTitleEnabled: true,
       largeTitleDisplayMode: Ti.UI.iOS.LARGE_TITLE_DISPLAY_MODE_ALWAYS
   });
    
   var nav = Ti.UI.iOS.createNavigationWindow({
       window: win
   });
    
   win.add(Ti.UI.createLabel({
       title: 'Hello world!'
   }));
    
   nav.open();

Expected behavior: A large window title should be shown. Change the largeTitleDisplayMode to Ti.UI.iOS.LARGE_TITLE_DISPLAY_MODE_NEVER and it should not show the large title anymore.

Eric Merriman 2017-08-17

Moving this out of 6.2.0 so we can address TIMOB-24775. Both with be included in our release for iOS 11 support.
Vijay Singh 2017-09-14

[~hknoechel] Can you create back ported PR for 6_3_X? Thanks.
Hans Knöchel 2017-09-14

PR (6_3_X): https://github.com/appcelerator/titanium_mobile/pull/9431
Samir Mohammed 2017-10-11

Verified feature on 6.3.0.v20171011114247 Test and other information can be found at: https://github.com/appcelerator/titanium_mobile/pull/9431 (6_3_X) Waiting for Master Branch for 7.0.0 testing.
Samir Mohammed 2017-10-11

^ Verified improvement in SDK Version 7.0.0.v20171011152516

Hans Knöchel 2017-10-20

Reopening an edge-case we may missed before:

   var win = Ti.UI.createWindow( {
       backgroundColor : 'white'
   });
   
   var btn = Ti.UI.createButton({
     title: 'Trigger'
   });
   
   btn.addEventListener('click', openWindow);
   win.add(btn);
   
   var nav = Ti.UI.iOS.createNavigationWindow({
     window: win
   });
   
   nav.open();
   
   function openWindow() {
     var win = Ti.UI.createWindow( {
         backgroundColor : 'white'
     } );
   
     nav.openWindow(win);
   }

Expected behavior: No error-log shown

Hans Knöchel 2017-10-20

PR (master): https://github.com/appcelerator/titanium_mobile/pull/9541 PR (6_3_X): https://github.com/appcelerator/titanium_mobile/pull/9542
Samir Mohammed 2017-10-26

6_3_X FR passed and Merged: https://github.com/appcelerator/titanium_mobile/pull/9542
Eric Wieber 2017-11-14

Verified in SDK builds 6.3.0.GA & 7.0.0.v20171114134144

JSON Source