[TIMOB-24903] Android: "touchFeedback" not working if borderRadius is set

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2017-07-11T17:04:19.000+0000
Affected Version/s	Release 6.1.0
Fix Version/s	Release 6.2.0
Components	Android
Labels	android, touchfeedback, ui
Reporter	Carlos Henrique Zinato
Assignee	Gary Mathews
Created	2017-06-28T10:59:38.000+0000
Updated	2017-07-12T22:00:38.000+0000

Description

The new touchFeedback and touchFeedbackColor are awesome but you can't use it when a view has borderRadius set. So is not possible to do a circle with the ripple effect =/ How to reproduce:

var win = Ti.UI.createWindow({backgroundColor: '#bebdda'}),
    v = Ti.UI.createView({
        width: 140,
        height: 140,
        backgroundColor: '#becedf',
        touchFeedback: true,
        touchFeedbackColor: '#7d93ab',
        elevation: 20,
        borderRadius: 70
    });
win.add(v);
win.open();

Thanks!

Comments

Gary Mathews 2017-07-03

master: https://github.com/appcelerator/titanium_mobile/pull/9188
Lokesh Choudhary 2017-07-10

-Failing review as I see a crash on android 5.1.1.-
Lokesh Choudhary 2017-07-11

FR Passed. PR Merged.
Lokesh Choudhary 2017-07-12

Verified the fix with SDK 6.2.0.v20170711165607. touchfeedback works as expected to show the ripple effect. 1.Checked with borderRadius & without. 2.Checked with various values of borderRadius. Closing. Studio Ver: 4.9.0.201705302345 SDK Ver: 6.2.0.v20170711165607 OS Ver: 10.12.3 Xcode Ver: Xcode 8.3.3 Appc NPM: 4.2.9 Appc CLI: 6.2.2 Ti CLI Ver: 5.0.14 Alloy Ver: 1.9.11 Node Ver: 6.10.1 Java Ver: 1.8.0_101 Devices: ⇨ google Nexus 5 --- Android 6.0.1 Emulator: Android 7.0

JSON Source