[TIMOB-24920] Android: Allow selecting stream type in Ti.Media.Sound (instead of always using STREAM_MUSIC)
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2017-08-15T01:42:13.000+0000 |
| Affected Version/s | Release 6.1.1 |
| Fix Version/s | Release 6.2.0 |
| Components | Android |
| Labels | android, sound, streaming |
| Reporter | David Bankier |
| Assignee | Gary Mathews |
| Created | 2017-07-03T03:00:07.000+0000 |
| Updated | 2017-08-18T23:58:23.000+0000 |
Description
This will allow us to (properly) select, e.g. using the earpiece to playing the sound through the speaker.
PR on 6_1_X: https://github.com/appcelerator/titanium_mobile/pull/9187
Hey there and thank you for the PR! In order to review it, we always need to receive PR's for the master branch first and then consider to backport it to other versions. In this case, as it is an improvement, it would go into 6.2.0, so master is the best choice anyway. Can you do that or should we help cherry-picking it? Thanks again, greta contribution! :-)
New PR: https://github.com/appcelerator/titanium_mobile/pull/9190
6_2_X: https://github.com/appcelerator/titanium_mobile/pull/9306
FR Passed for both master & 6.2.0 PR's. PR's merged.
Verified the fix in 6.2.0.v20170818105443 & 7.0.0.v20170818115004. Closing. Studio Ver: 4.9.1.201707200100 SDK Ver: 6.2.0.v20170818105443, 7.0.0.v20170818115004 OS Ver: 10.12.3 Xcode Ver: Xcode 8.3.3 Appc NPM: 4.2.9 Appc CLI: 6.2.3 Ti CLI Ver: 5.0.14 Alloy Ver: 1.9.13 Node Ver: 6.10.1 Java Ver: 1.8.0_101 Devices: ⇨ google Nexus 5 --- Android 6.0.1 ⇨ google Pixel --- Android 7.1.1