[TIMOB-24988] Android: Ti.Network.Cookie isValid() is missing
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2017-08-07T18:15:21.000+0000 |
| Affected Version/s | Release 6.1.1 |
| Fix Version/s | Release 6.2.0 |
| Components | Android |
| Labels | android, cookie, parity |
| Reporter | Michael Gangolf |
| Assignee | Gary Mathews |
| Created | 2017-07-20T08:21:46.000+0000 |
| Updated | 2017-08-15T22:53:54.000+0000 |
Description
The method
isValid() in Titanium.Network.Cookie is missing on Android.
PR: https://github.com/appcelerator/titanium_mobile/pull/9230 Test-Case:
var cookie1 = Ti.Network.createCookie({ domain: 'example.com', name: 'test_cookie', value: '12', path: '/' }); var cookie2 = Ti.Network.createCookie({ name: 'test_cookie', value: '12', path: '/' }); console.log('is cookie valid: ' + cookie1.isValid()); console.log('is cookie valid: ' + cookie2.isValid());FR passed for master. Waiting for backport 6.2.X PR
6_2_X: https://github.com/appcelerator/titanium_mobile/pull/9262
[~kiguchi] The docs say we don't have a Windows equivalent for Ti.Network.COokie#isValid(). We may want to open a ticket to add it there as well for parity.
FR passed for backport. PR merged.
Verified the fix in SDK 6.2.0.v20170815130745. Closing. Studio Ver: 4.9.1.201707200100 SDK Ver: 6.2.0.v20170815130745 OS Ver: 10.12.3 Xcode Ver: Xcode 8.3.3 Appc NPM: 4.2.9 Appc CLI: 6.2.3 Ti CLI Ver: 5.0.14 Alloy Ver: 1.9.13 Node Ver: 6.10.1 Java Ver: 1.8.0_101 Devices: ⇨ samsung SM-G955U1 --- Android 7.0 Emulator : Android 6.0, Android 5.1.1