Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-25018] Add Windows support to the test script

GitHub Issuen/a
TypeTechnical task
PriorityNone
StatusClosed
ResolutionDone
Resolution Date2017-11-30T14:59:14.000+0000
Affected Version/sn/a
Fix Version/sn/a
Componentsn/a
Labelsn/a
ReporterEwan Harris
AssigneeEwan Harris
Created2017-07-25T12:47:02.000+0000
Updated2017-11-30T14:59:14.000+0000

Description

Windows support needs to be added to the test.js script. We need to consider support a little differently to iOS and Android as it will need to hit both ws-local and wp-emulator targets At a high level here are the tasks

Allow a user to pass in a target

** As we allow a user to pass in multiple platforms we should just outright error if platforms.length >1 and target is defined ** This target should then be used passed to the build phase

When no target is defined select a default

** In keeping with the other probably want to target wp-emulator when not defined

Make sure it does not break Android and iOS usage

Review https://github.com/appcelerator/titanium_mobile_windows/blob/66ccc0a080360d147dd2b59c748a075b87107233/Tools/Scripts/build/test.js to see whether there is any Windows specific logic we need to handle (device id, copying windows SDK across, specific name for each platform we target etc.)

Comments

  1. Ewan Harris 2017-07-25

    Initial work pushed in https://github.com/appcelerator/titanium-mobile-mocha-suite/pull/17/commits/4b75b3f057ad8771bc0d0f2ebf249096462a9207 need to test that I didn't break current usage in titanium_mobile. Keeping scope limited to usage within titanium_mobile_windows i.e single platform usage examples node test.js -p windows -T ws-local -> builds to ws-local node test.js -p windows -T wp-emulator -C 10-0-1 -> build to wp-emulator 10-0-1 device id node test.js -p windows -C 10-0-1 -> errors out node test.js -p windows,android -T ws-local -> errors out
  2. Ewan Harris 2017-08-30

    Note to self, split out the SDK installation steps out of the test scripts. Then we can see whether the test do really take 20 minutes on Windows, or whether that's just because it's gotta download an SDK and that counts towards our test time
  3. Ewan Harris 2017-08-30

    Further note to self, lets mirror the flow of titanium_mobile if we can, build the SDK, then run the unit test in a separate 'step' splitting out ws-local and wp-emulator onto different nodes. We probably could also write some nice new build scripts for titanium_mobile_windows that match titanium_mobile?

JSON Source