[TIMOB-25176] CLI: SDK 7 broken on node 4
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2017-08-16T13:30:04.000+0000 |
| Affected Version/s | Release 7.0.0 |
| Fix Version/s | Release 7.0.0 |
| Components | n/a |
| Labels | n/a |
| Reporter | Ewan Harris |
| Assignee | Ewan Harris |
| Created | 2017-08-16T11:13:05.000+0000 |
| Updated | 2017-11-15T08:06:50.000+0000 |
Description
Description
We're using const in files that don't have'use strict', node 4 doesn't like this, if we want node 4 support then we need to add it. If we wont fix we need to update all the Windows jenkins slaves to >=6 as this is currently breaking all Windows builds https://jenkins.appcelerator.org/blue/organizations/jenkins/titanium-sdk%2Ftitanium_mobile_windows/detail/PR-1073/2/pipeline/38/
https://github.com/appcelerator/titanium_mobile/pull/9322
I also enabled the eslint rule for
'use strict'on titanium_mobile master branch, and set it to be ES6/script (the base config is ES2017 and module). Then I fixed the few remaining files that didn't have'use strict'at top.Closing ticket as Release 7.0.0 requires minimum of node 8.X