[TIMOB-25196] iOS: CLI throws ATS-warning although *.appcelerator.com is properly whitelisted
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Low |
Status | Open |
Resolution | Unresolved |
Affected Version/s | n/a |
Fix Version/s | n/a |
Components | iOS |
Labels | cb-tooling |
Reporter | Hans Knöchel |
Assignee | Unknown |
Created | 2017-08-27T16:44:51.000+0000 |
Updated | 2020-01-30T22:59:02.000+0000 |
Description
_Following up on an email-thread with [~ben.bahrenburg@gmail.com]._
When manually whitelisting ATS domains, he added
appcelerator.com
to the ATS-configuration, but there was still a warning thrown:
[WARN] : ATS enabled, however *.appcelerator.com are not whitelisted
[WARN] : Consider setting the "ios.whitelist.appcelerator.com" property in the tiapp.xml to "true"
Looking into the [related code](https://github.com/appcelerator/titanium_mobile/blob/master/iphone/cli/commands/_build.js#L4001-L4002), it falls through the if-case and lands in the else-case, because he manages the ATS-setting manually instead of setting the ios.whitelist.appcelerator.com
property to true.
So what should the code do? It should detect ATS references properly in [here](https://github.com/appcelerator/titanium_mobile/blob/master/iphone/cli/commands/_build.js#L2323-L2324), so it either checks if the property is enabled, but also checks if it is manually set.
No comments