[TIMOB-25203] Remove 8.1 from CI/CD build process

GitHub Issue	n/a
Type	Sub-task
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2017-11-02T19:50:09.000+0000
Affected Version/s	n/a
Fix Version/s	Release 7.0.0
Components	Windows
Labels	n/a
Reporter	Ewan Harris
Assignee	Ewan Harris
Created	2017-08-29T10:07:15.000+0000
Updated	2017-11-17T01:24:29.000+0000

Description

This sub-task is to remove 8.1 from the Jenkins build process, it's pretty much just nuke [these configs](https://github.com/appcelerator/titanium_mobile_windows/blob/f335f2ba034ba707d349cb2e91f6e7738b98888b/Jenkinsfile#L94-L130), and then basking in the glory of the reducing the build times. Extra points for simplifying any of the necessary build logic

Comments

Ewan Harris 2017-08-29

https://github.com/ewanharris/titanium_mobile_windows/commit/6d04360337e2222eb3901688ccc93444bab1b584 Will PR when removal is okayed
Ewan Harris 2017-08-29

Seeing as this will properly kill it off as the libs will stop being made we should probably land this either after or at the same time as some work to drop support for building from the CLI
Ewan Harris 2017-08-30

https://github.com/appcelerator/titanium_mobile_windows/pull/1088 Taken over by https://github.com/appcelerator/titanium_mobile_windows/pull/1132
Kota Iguchi 2017-10-11

[~eharris] Now I can see that 8.1 support is [removed from master build](https://jenkins.appcelerator.org/blue/organizations/jenkins/titanium-sdk%2Ftitanium_mobile_windows/detail/master/169/pipeline) (y) but it seems it still remains when you [build against PR](https://jenkins.appcelerator.org/blue/organizations/jenkins/titanium-sdk%2Ftitanium_mobile_windows/detail/PR-1138/3/pipeline/39). Could you look into this?
Ewan Harris 2017-10-11

[~kiguchi] It looks to have been taken in https://jenkins.appcelerator.org/job/titanium-sdk/job/titanium_mobile_windows/view/change-requests/job/PR-1120/, looking at GitHub I think you might need to update the branch for PR 1138 as it shows the update branch button

Kota Iguchi 2017-10-11

Yes (y)(y) But hmm I hit [another error](https://jenkins.appcelerator.org/blue/organizations/jenkins/titanium-sdk%2Ftitanium_mobile_windows/detail/PR-1120/8/pipeline)

   [build] Running batch script
   
   C:\Jenkins\workspace\nium_mobile_windows_PR-1120-YGJD5HBUMZUSYY6FJG5FFLOUEAB4VYEGBN35MYPAEIZVFASTZCEQ\Tools\Scripts\build>node setupSDK.js --branch master 
   
   module.js:327
       throw err;
       ^
   
   Error: Cannot find module 'C:\Jenkins\workspace\nium_mobile_windows_PR-1120-YGJD5HBUMZUSYY6FJG5FFLOUEAB4VYEGBN35MYPAEIZVFASTZCEQ\Tools\Scripts\build\setupSDK.js'

Ewan Harris 2017-10-11

Ah, I think we need to unstash that folder, no idea how we only just hit that now! :P I'll push some changes now to try fix, will update here
Abir Mukherjee 2017-11-02

PR is merged. Need to check if this was validated by QE before closing.

JSON Source