GitHub Issue | n/a |
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2017-09-05T21:32:36.000+0000 |
Affected Version/s | Release 6.2.0 |
Fix Version/s | Release 6.2.0 |
Components | iOS |
Labels | fireevent, ios, regression, webview |
Reporter | Anthony Chung |
Assignee | Hans Knöchel |
Created | 2017-09-01T02:52:38.000+0000 |
Updated | 2017-09-06T18:19:11.000+0000 |
regression error:
click href link in webview that uses fireevent causes crash
crash occurs when using
6.2.0.v20170831112315
Same code works fine when using
6.1.2.GA
6.1.0.GA
note in test env
run-on-main-thread is not set
jscore framework is not used
simulator log code and safari debug inspector of the webview attached.
Hey there, thanks for the report! It -could be- is caused by [this line-change](https://github.com/appcelerator/titanium_mobile/commit/8296a594b523996ca057cf1352e23bce6ae43af7#diff-c3b1f31b61a796bea16bd0ed1610b084R66) as part of TIMOB-24769. We will investigate ist immediately and fix it for the GA, thank you! For QE: I also need to validate all other
[SBJSON fragmentWithString:]
calls to verify it did not broke other places as well. Reproducible test-case:PR (master): https://github.com/appcelerator/titanium_mobile/pull/9386 PR (6_2_X): https://github.com/appcelerator/titanium_mobile/pull/9387
More test-cases for the above SBJSON-migration:
FR Passed, using: MacOS 10.12.6 (16G24b) Studio 4.9.0.201705302345 Ti SDK 6.2.0.v20170901091533 Appc NPM 4.2.9 Appc CLI 6.2.4-master.9 Alloy 1.9.13 Xcode 8.3.3 (8E3004b) Events successfully fire and are caught in webviews using href links. Tested using the provided sample code, webview suite, and new webview checks
I've tested this in production app, and the issue has been resolved. Great work.
Verified in SDK builds 6.2.0.v20170906064110 & 7.0.0.v20170906103333