Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-25285] iOS: Error out on duplicate third-party frameworks

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2017-09-19T15:37:08.000+0000
Affected Version/sRelease 6.2.0
Fix Version/sRelease 6.2.1
ComponentsiOS
Labelsn/a
ReporterJan Vennemann
AssigneeJan Vennemann
Created2017-09-14T21:43:49.000+0000
Updated2017-09-19T22:26:13.000+0000

Description

The new framework integration introduced in 6.2.0 contains a minor bug, where duplicate frameworks will be silently ignored, rather than informing the developer so he can select which framework should be used. Currently, the hook will simply use the first framework found. The intended behavior should be as followed: - The build should fail if two frameworks with the same name are used across the app project. Framework can be provided by modules or by placing them in the project's platform/ios folder. - This gives the developer the opportunity to delete the undesired framework to make sure the correct version of the framework is used.

Comments

  1. Jan Vennemann 2017-09-15

    PR (master): https://github.com/appcelerator/titanium_mobile/pull/9437 PR (6_3_X): https://github.com/appcelerator/titanium_mobile/pull/9440 PR (6_2_X): https://github.com/appcelerator/titanium_mobile/pull/9441
  2. Eric Wieber 2017-09-19

    FR Passed. Tested using frameworks in modules (both local and system) and in the platform folder on both classic and Alloy projects. Error and build failure was correctly shown each time.
  3. Eric Wieber 2017-09-19

    Verified in SDK builds 6.2.1.v20170919115451 & 6.3.0.v20170919115627 & 7.0.0.v20170919115520

JSON Source