[TIMOB-25322] iOS: Geolocation should be able to handle iOS 11 permission upgrade, Media should warn when writing to gallery

GitHub Issue	n/a
Type	Improvement
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2017-10-27T18:40:43.000+0000
Affected Version/s	n/a
Fix Version/s	Release 6.3.0
Components	iOS
Labels	n/a
Reporter	Jeroen van Dijk
Assignee	Hans Knöchel
Created	2017-09-20T10:37:29.000+0000
Updated	2017-10-31T03:42:06.000+0000

Description

Context

Since iOS 11 the location permission model is more strict. Developers are not allowed to support "Always" only anymore. Apple advices a 2 step approach to ask users for the "Always" support as explained in this blogpost: https://m.rover.io/wwdc-2017-update-significant-updates-to-location-permissions-coming-with-ios-11-41f96001f87f The current geolocation module doesn't support this strategy though due to this check: https://github.com/appcelerator/titanium_mobile/blob/822b2eeca1af07d6405ec47e5a33568b12362939/iphone/Classes/GeolocationModule.m#L816 Because of this, you won't be able to support the advised approach to require users to authorise the 'Always' mode which is needed to support geofences and beacon technology. Read more [here](https://developer.apple.com/documentation/corelocation/choosing_the_authorization_level_for_location_services/request_always_authorization). Edit by Hans: In addition, there is another new constant called NSPhotoLibraryAddUsageDescription that is now required when attempting to write to the photo-gallery. It works without this change, but this change will warn the user if it's not set to track down the changes more easily. P.S.: (by Hans): Apple made a typo in the above article. It is NSLocationAlwaysAndWhenInUseUsageDescription, not NSLocationAlwaysAndWhenInUsageDescription. I filed a radar for Apple regarding that.

Comments

Hans Knöchel 2017-09-20

PR (master): https://github.com/appcelerator/titanium_mobile/pull/9458 PR (6_3_X): (Awaiting initial fix to be accepted) *Test-Case*:

Add the NSLocationAlwaysAndWhenInUseUsageDescription to your plist and ensure location services (GPS) are turned on

Click the first button. It should display the options "When In Use" or "Never"

Click the second button (to request "Always" permissions). It should display both options (When in Use + Always), select "Always"

Click the third button. It should log the current location and no warning

Reset the simulator and try to hit the third button without granting any permissions. It should work but throw a warning in the logs, telling you to request permissions beforehand when using iOS 11 and later.

*Code*:

   var win = Ti.UI.createWindow({
       backgroundColor: '#fff',
       layout: 'vertical'
   });
    
   var btn1 = Ti.UI.createButton({
       title: '1. Request "When In Use" authorization',
       top: 50
   });
    
   btn1.addEventListener('click', function() {
       if (Ti.Geolocation.hasLocationPermissions(Ti.Geolocation.AUTHORIZATION_WHEN_IN_USE)) {
         Ti.API.info('Success (has "when in use" already)');
         return;
       }
   
       Ti.Geolocation.requestLocationPermissions(Ti.Geolocation.AUTHORIZATION_WHEN_IN_USE, function(e) {
         Ti.API.info('Success (when in use): ' + e.success);
         if (!e.success) {
           Ti.API.error('Error (when in use): ' + e.error);
         }
       });
   });
    
   var btn2 = Ti.UI.createButton({
       title: '2. Upgrade to "Always" authorization',
       top: 50
   });
    
   btn2.addEventListener('click', function() {
     if (Ti.Geolocation.hasLocationPermissions(Ti.Geolocation.AUTHORIZATION_ALWAYS)) {
       Ti.API.info('Success (has "always" already)');
       return;
     }
     Ti.Geolocation.requestLocationPermissions(Ti.Geolocation.AUTHORIZATION_ALWAYS, function(e) {
       Ti.API.info('Success (always): ' + e.success);
       if (!e.success) {
         Ti.API.error('Error (always): ' + e.error);
       }
     });
   });
    
   var btn3 = Ti.UI.createButton({
       title: '3. Use Ti.Geolocation API\'s',
       top: 50
   });
    
   btn3.addEventListener('click', function() {
     
     if (!Ti.Geolocation.hasLocationPermissions(Ti.Geolocation.AUTHORIZATION_ALWAYS) && !Ti.Geolocation.hasLocationPermissions(Ti.Geolocation.AUTHORIZATION_WHEN_IN_USE)) {
       Ti.API.warn('Prepare: Probably will warn on iOS 11 (only) because trying to access Ti.Geolocation API\'s without authorizing before');
     }
     
     Ti.Geolocation.getCurrentPosition(function(e) {
       Ti.API.info(e);
     });
   });
    
   win.add(btn1);
   win.add(btn2);
   win.add(btn3);
   win.open();

Vijay Singh 2017-10-09

[~hknoechel] can you add test case for using "NSPhotoLibraryAddUsageDescription" key and back port for 6_3_X? Thanks!

Vijay Singh 2017-10-10

Test Case (Using NSPhotoLibraryAddUsageDescription) - Do not add 'NSPhotoLibraryAddUsageDescription' in tiapp.xml. It should log error message. If added no error log.

   var win = Ti.UI.createWindow({
       backgroundColor: "#fff"
   });
    
   var btn = Ti.UI.createButton({
       title: "Open Camera",
       top: 50
   });
   btn.addEventListener("click", function() {
       Ti.Media.showCamera({
           showControls: true,
           success: function(e) {
               Ti.Media.hideCamera();
           },
           saveToPhotoGallery: true,
           mediaTypes: Ti.Media.MEDIA_TYPE_PHOTO
       });
   });
    
   win.add(btn);
   win.open();

Hans Knöchel 2017-10-10

Backport (6_3_X): https://github.com/appcelerator/titanium_mobile/pull/9514 Another test-case for the saveToGallery changes:

   var win = Ti.UI.createWindow({
       backgroundColor: "#fff"
   });
    
   var btn = Ti.UI.createButton({
       title: "Save to Gallery",
       top: 50
   });
   btn.addEventListener("click", function() {
       var view = Ti.UI.createView({
         width: 1000,
         height: 1000,
         backgroundColor: 'red'
       });
       
       Ti.Media.saveToPhotoGallery(view.toImage(), {
         success: function(e) {
           if (!e.success) {
             Ti.API.error('Error saving file! Error: ' + e.error);
             return;
           }
           Ti.API.error('Successfully saved file!');
         },
         error: function(e) {
           Ti.API.error('Error saving file! Error: ' + e.error);
         }
       })
   });
    
   win.add(btn);
   win.open();

Hans Knöchel 2017-10-19

Reopening ticket to include additional changes now being more clear. Here is what's exactly going on when targeting iOS 11:
You *always* need to include the NSLocationWhenInUseUsageDescription key, whether or not you don't plan to use when-in-use permissions. This is a constraint added by Apple to avoid crawling geolocation-data.

If you wan to have the "when-in-use" permissions, you still only need the NSLocationWhenInUseUsageDescription key covered above

If you want to have the "always" permissions, you need all three keys:
* NSLocationWhenInUseUsageDescription * NSLocationAlwaysUsageDescription * NSLocationAlwaysAndWhenInUseUsageDescription
If you are missing required keys, Titanium will now throw very descriptive error-logs to ensure you don't miss anything
PR to implement those improvements coming later today.
Hans Knöchel 2017-10-19

PR (master): https://github.com/appcelerator/titanium_mobile/pull/9537 PR (6_3_X): https://github.com/appcelerator/titanium_mobile/pull/9538
Eric Wieber 2017-10-31

FR Passed. The WhenInUse key is always required. To have "always" permissions, both Always and AlwaysAndWhenInUse keys are required. Appropriate error messages appear if the required keys are not present.
Eric Wieber 2017-10-31

Verified in SDK builds 6.3.0.v20171030181741 & 7.0.0.v20171030085253

JSON Source

[TIMOB-25322] iOS: Geolocation should be able to handle iOS 11 permission upgrade, Media should warn when writing to gallery

Description

Context

Comments

Add the NSLocationAlwaysAndWhenInUseUsageDescription to your plist and ensure location services (GPS) are turned on

Click the first button. It should display the options "When In Use" or "Never"

Click the second button (to request "Always" permissions). It should display both options (When in Use + Always), select "Always"

Click the third button. It should log the current location and no warning

Reset the simulator and try to hit the third button without granting any permissions. It should work but throw a warning in the logs, telling you to request permissions beforehand when using iOS 11 and later.

You always need to include the `NSLocationWhenInUseUsageDescription` key, whether or not you don't plan to use when-in-use permissions. This is a constraint added by Apple to avoid crawling geolocation-data.

If you wan to have the "when-in-use" permissions, you still only need the `NSLocationWhenInUseUsageDescription` key covered above

If you want to have the "always" permissions, you need all three keys:

If you are missing required keys, Titanium will now throw very descriptive error-logs to ensure you don't miss anything

[TIMOB-25322] iOS: Geolocation should be able to handle iOS 11 permission upgrade, Media should warn when writing to gallery

Description

Context

Comments

Add the NSLocationAlwaysAndWhenInUseUsageDescription to your plist and ensure location services (GPS) are turned on

Click the first button. It should display the options "When In Use" or "Never"

Click the second button (to request "Always" permissions). It should display both options (When in Use + Always), select "Always"

Click the third button. It should log the current location and no warning

Reset the simulator and try to hit the third button without granting any permissions. It should work but throw a warning in the logs, telling you to request permissions beforehand when using iOS 11 and later.

You *always* need to include the NSLocationWhenInUseUsageDescription key, whether or not you don't plan to use when-in-use permissions. This is a constraint added by Apple to avoid crawling geolocation-data.

If you wan to have the "when-in-use" permissions, you still only need the NSLocationWhenInUseUsageDescription key covered above

If you want to have the "always" permissions, you need all three keys:

If you are missing required keys, Titanium will now throw very descriptive error-logs to ensure you don't miss anything

You always need to include the `NSLocationWhenInUseUsageDescription` key, whether or not you don't plan to use when-in-use permissions. This is a constraint added by Apple to avoid crawling geolocation-data.

If you wan to have the "when-in-use" permissions, you still only need the `NSLocationWhenInUseUsageDescription` key covered above