[TIMOB-25355] iOS 11: Update Ti.Facebook iOS to 4.27.0
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Low |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2017-09-29T13:25:54.000+0000 |
Affected Version/s | Release 6.2.2 |
Fix Version/s | Release 6.3.0 |
Components | iOS |
Labels | n/a |
Reporter | Hans Knöchel |
Assignee | Hans Knöchel |
Created | 2017-09-27T21:46:39.000+0000 |
Updated | 2017-11-09T23:32:31.000+0000 |
Description
The Facebook iOS SDK 4.27.0 improves the support for Xcode 9 and iOS 11, so we should adopt it as well.
PR (ti.facebook/master): https://github.com/appcelerator-modules/ti.facebook/pull/87 PR (ti/master): https://github.com/appcelerator/titanium_mobile/pull/9486 PR (ti/6_3_X): https://github.com/appcelerator/titanium_mobile/pull/9487 Test-Case: Simply run the usual Facebook smoke-tests. If the build succeeds and the existing API's are working as before, we are good to go. OT // I may start writing unit-tests inside Xcode for this as well, so it could be hooked into the build-pipeline. If it works out, we could do the same for the core, to have more core-close tests compared to the mocha-tests as well.
I ran the demo Facebook app from the docs using the version and app build without any issues.