[TIMOB-25424] iOS: Unnecessary symbols compiled to the app
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Critical |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2017-12-14T15:58:10.000+0000 |
Affected Version/s | Release 6.3.0 |
Fix Version/s | Release 7.0.1 |
Components | iOS |
Labels | n/a |
Reporter | Hans Knöchel |
Assignee | Hans Knöchel |
Created | 2017-10-21T22:13:20.000+0000 |
Updated | 2018-08-30T16:07:26.000+0000 |
Description
When using 6.3.x, there were some reports of rejected apps because of the missing NSAppleMusicUsageDescription which we fixed a while ago but popped up with some other changes the last month. This ticket should solve those issues as well as wrapping other API's that were currently compiled although not used (e.g. Ti.WatchSession).
Due to the schedule for 7.0.0 versus the remaining work, moving to 7.1.0
Moving into 7.0.0 again, since the PR was already ready but not submitted and it may block developers. PR (master): https://github.com/appcelerator/titanium_mobile/pull/9586 PR (7_0_X): https://github.com/appcelerator/titanium_mobile/pull/9665 Test-Case:
Use a Ti.Media related API like
Ti.Media.showCamera(args)
but no music-related oneSubmit the App to the store
Expected behavior: TheNSAppleMusicUsageDescription
is not required, the app will not be rejected.Moving out of 7.0.0 again as the latest PR still seems to contain a disallowed symbol. I am in contact with Apple to clear what they are really complaining about.
Do you have a quick fix ? I can't publish my app because of this. I use Ti.Media to file but not to music. If i upload a new binary without "NSAppleMusicUsageDescription" key in tiapp, my binary is refused and if i include it, Apple saiys i didn't use Apple Music on my app, so the app didn't pass the validation process. The message from Apple i've got : Guideline 4.5.2 - Design - Apple Sites and Services Your app uses the Apple Music API but does not display or appropriately use standard media controls, such as "play," "pause," and "skip." Specifically, the app does not include any Apple Music API controls. »
[~thomas.webgo@gmail.com] You can describe to them that you do not use them and that it will not pop-up. The fix can be taken from the above pull-request and be patched with your local SDK. Please try that and let us know. Worst case, I'll try to create a custom build for you!
I've decided to provide a build for the ones interested - it's a 6.3.0.GA + the above patch, nothing more. I cherry-picked the commits but also needed to resolve a few merge conflicts. Please test it wisely before uploading it again, thx! Download: https://www.dropbox.com/s/2q4vfn2x581oibr/mobilesdk-6.3.1-media.zip?dl=0
Verified in SDK builds: 7.0.1.v20171214075504 & 7.1.0.v20171214080308
Today I had a rejection from an SDK 7.1.1.GA build for a missing "NSPhotoLibraryUsageDescription" key. My app does not use the photo library.
[~kosso] Did you try with 7.3.0? We had some additional fixes for Ti.Media in it.
I did not. I didn't want to try too many times, and have to keep bumping up the version number. To get it submitted, I just added the key to tiapp.xml with a "To Save Images" value and it processed OK. I will have a try with 7.3.0 for the next beta update.