Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-25437] iOS: dest is undefined error when using LaunchLogos

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2017-10-26T22:57:32.000+0000
Affected Version/sRelease 6.3.0
Fix Version/sRelease 6.3.0
ComponentsiOS
Labelsn/a
ReporterEwan Harris
AssigneeEwan Harris
Created2017-10-24T11:58:26.000+0000
Updated2017-10-30T21:25:31.000+0000

Description

Description

Debug log from slack https://gist.github.com/dave255/d1556df4bd58b49d23210cf586b20c7f When enable-launch-screen-storyboard is set to true in the tiapp, and a custom LaunchLogo is defined for a device group e.g. LaunchLogo~iphone.png, the build will error with the above log Steps to reproduce 1. Download https://github.com/ewanharris/TIMOB-25437 and build it

Actual

Error above

Expected

No error Addendum In https://github.com/appcelerator/titanium_mobile/pull/9535 I added use strict to _build.js to get around some const/let errors in some places. This however has exposed a bug in the JS code where dest is not defined here https://github.com/appcelerator/titanium_mobile/blob/6_3_X/iphone/cli/commands/_build.js#L5284, this is now an error because we're in strict mode and this is a no-no, there's probably quite a bit of this in the file There's two options

Remove the 'use strict' fix the usage of const and let

Figure out some way of running eslint on the file to tease out all the errors in strict mode

I vote #1

Comments

  1. Ewan Harris 2017-10-24

    [~hknoechel] [~emerriman] fyi
  2. Ewan Harris 2017-10-24

    PR here https://github.com/appcelerator/titanium_mobile/pull/9549 Test case demo here https://github.com/ewanharris/TIMOB-25437 Updating description to reflect demo
  3. Abir Mukherjee 2017-10-26

    Passed FR. PR merged. Changes are seen in 6.3.0.v20171030133255

JSON Source