[TIMOB-25508] Android: Forced rebuild loop due to tiapp.xml navbar-hidden changed

GitHub Issue	n/a
Type	Bug
Priority	None
Status	Closed
Resolution	Fixed
Resolution Date	2017-12-13T16:52:25.000+0000
Affected Version/s	Release 6.3.0
Fix Version/s	Release 7.0.1
Components	Android
Labels	merge-7.0.1
Reporter	Jan Vennemann
Assignee	Jan Vennemann
Created	2017-11-13T19:22:10.000+0000
Updated	2017-12-19T23:20:49.000+0000

Description

Android builds are stuck in a forced rebuild loop due to changes to tiapp.xml navbar-hidden setting. *Steps to reproduce the behavior*

Run a clean build

Run a second build

*Actual behvior* Second build and onward always get forced to a full rebuild, indicated by the following logs:

[INFO]  Forcing rebuild: tiapp.xml navbar-hidden changed since last build
[INFO]    Was: false
[INFO]    Now: undefined

*Expected behavior* The build does an incremental build instead of a full rebuild. The above log message should not appear. *Additional Notes* Only occurs with fixes from CLI-1278.

Comments

Jan Vennemann 2017-11-13

https://github.com/appcelerator/titanium_mobile/pull/9593
Hans Knöchel 2017-12-13

[~jvennemann] Missing backport and test-case
Jan Vennemann 2017-12-13

Damn, forgot to update the ticket. Backport is available at https://github.com/appcelerator/titanium_mobile/pull/9642. A test case is already included in the description of this ticket. Reproducible with current 7.0.0.GA as the fix from CLI-1278 is included there.
Josh Longton 2017-12-13

FR Passed * Master has been merged. * 7_0_X has been merged
Lokesh Choudhary 2017-12-19

Verified the fix with SDK 7.0.1.v20171218104141 & 7.1.0.v20171218101353. Closing. Studio Ver: 5.0.0.201712081732 SDK Ver: 7.0.1.v20171218104141, 7.1.0.v20171218101353 OS Ver: 10.12.3 Xcode Ver: Xcode 8.3.3 Appc NPM: 4.2.11 Appc CLI: 7.0.1-master.5 Daemon Ver: 1.0.1 Ti CLI Ver: 5.0.14 Alloy Ver: 1.10.10 Node Ver: 8.9.1 Java Ver: 1.8.0_101 Devices: ⇨ google Pixel — Android 7.1.1 ⇨ google Nexus 5 — Android 6.0.1

JSON Source