Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-25561] CLI: Module build should error if the apiversion in manifest does not match the SDKs apiversion

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2017-11-28T20:40:31.000+0000
Affected Version/sRelease 6.0.0, Release 5.5.0
Fix Version/sRelease 7.0.0
ComponentsTooling
Labelscb-tooling, qe-6.0.0, windows
ReporterEwan Harris
AssigneeEwan Harris
Created2017-11-27T10:07:57.000+0000
Updated2018-08-06T17:49:13.000+0000

Description

Description

When building a module if the apiversion in the manifest does not match the platforms apiversion in the SDK then the module build should fail. Currently if the apiversion is different then the build will take place and the user will produce a module that is not considered to be valid for the SDK it is build against. For example. * Developer rebuilds Android module for 6.0.0, forgetting to bump apiversion * User of module downloads the new module, and tries to build * Build fails as the apiversion does not match

Steps to reproduce

Create a module using ti create -p windows --type module --name mymodule --id com.my.mod

Change the maifest apiversion to 2

Build for Windows using 6.X SDK

Actual result

Build takes place despite the differing apiversions between SDK and module

Expected result

Build should fail as the apiversions are different

Comments

  1. Ewan Harris 2017-11-27

    https://github.com/appcelerator/titanium_mobile_windows/pull/1158
  2. Abir Mukherjee 2017-11-28

    Passed FR, PR merged.
  3. Eric Merriman 2018-08-06

    Cleaning up older fixed issues. If this issue should not have been closed as fixed, please reopen.

JSON Source