Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-25562] CLI: Automatically migrate native Android modules to SDK 7 during module-build

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2017-11-28T21:09:44.000+0000
Affected Version/sRelease 7.0.0
Fix Version/sRelease 7.0.0
ComponentsAndroid
Labelsandroid, migration, module
ReporterHans Knöchel
AssigneeHans Knöchel
Created2017-11-27T11:20:52.000+0000
Updated2017-12-09T10:37:52.000+0000

Description

The V8 update forces module developers to recompile their modules, which can be quite a pain when having many modules to maintain. I would propose a small module-build hook inside the _buildModule.js that takes care of this by detecting the currently selected SDK and then migrates the module automatically, by: - bumping the apiversion to 4 - setting the minimum-sdk to 7.0.0 - adding the arm64-v8a architecture - optionally (recommended): bumping the version to the next major to indicate a new major version We may want to ask the developer to confirm the changes, e.g. by printing the new file. It would greatly improve the dev-experience during module recompiling and could be the subject of our planned post about migrating to SDK 7.

Comments

  1. Hans Knöchel 2017-11-28

    PR (including some open discussions): https://github.com/appcelerator/titanium_mobile/pull/9631
  2. Lokesh Choudhary 2017-11-30

    Verified the fix with SDK 7.0.0.v20171129100330. Closing.
  3. Michael Gangolf 2017-12-09

    Little bug: description field will be the module name after an auto update. It is still in the .bak file so you can copy it over again
  4. Hans Knöchel 2017-12-09

    This is because the module template sets the description key to the module name by default: description: <%- moduleName %>. But I fixed it as part of TIMOB-25592, thanks!

JSON Source