Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-25601] Android: Remove "ti.cloudpush" module's "com.google.android.gms.version" metadata tag

GitHub Issuen/a
TypeBug
PriorityCritical
StatusClosed
ResolutionFixed
Resolution Date2017-12-14T22:25:39.000+0000
Affected Version/sRelease 7.0.0
Fix Version/sRelease 7.0.1
ComponentsAndroid
Labelsandroid, cloudpush
ReporterJoshua Quick
AssigneeGary Mathews
Created2017-12-12T20:01:36.000+0000
Updated2017-12-19T23:13:57.000+0000

Description

*Summary:* The Android "ti.cloudpush" module has a hardcoded Google Play Services version reference (ie: "com.google.android.gms.version") that it'll inject into the AndroidManifest.xml file in it's "timodule.xml" file. https://github.com/appcelerator-modules/ti.playservices/blob/master/android/timodule.xml This metadata tag needs to be deleted from the "timodule.xml". It is no longer needed since it'll be automatically injected by Titanium 7.0.0's new "ti.playservices" module. *Note:* This issue will cause a crash on app startup if the "ti.playerservices" module has been manually added above the "ti.cloudpush" module in the "tiapp.xml" file. This is because the last metadata tag ends up being the one read by the Google Play Services library and it'll throw an exception due to a version mismatch.

Comments

  1. Gary Mathews 2017-12-13

    cloudpush: https://github.com/appcelerator-modules/cloudpush/pull/35 5.0.1: https://github.com/appcelerator-modules/cloudpush/releases/tag/android-5.0.1
  2. Lokesh Choudhary 2017-12-14

    FR Passed. PR merged.
  3. Gary Mathews 2017-12-15

    *titanium_mobile* master: https://github.com/appcelerator/titanium_mobile/pull/9690 7_0_X: https://github.com/appcelerator/titanium_mobile/pull/9691
  4. Lokesh Choudhary 2017-12-19

    Verified the fix with SDK 7.0.1.v20171218104141 & 7.1.0.v20171218101353. Closing. Studio Ver: 5.0.0.201712081732 SDK Ver: 7.0.1.v20171218104141, 7.1.0.v20171218101353 OS Ver: 10.12.3 Xcode Ver: Xcode 8.3.3 Appc NPM: 4.2.11 Appc CLI: 7.0.1-master.5 Daemon Ver: 1.0.1 Ti CLI Ver: 5.0.14 Alloy Ver: 1.10.10 Node Ver: 8.9.1 Java Ver: 1.8.0_101 Devices: ⇨ google Pixel — Android 7.1.1 ⇨ google Nexus 5 — Android 6.0.1

JSON Source