[TIMOB-2565] Android: Video Player can't be added to a parent view (incompatible with iOS)
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | Low |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2011-12-06T15:19:54.000+0000 |
Affected Version/s | Release 1.7.2 |
Fix Version/s | Sprint 2011-46, Release 1.8.0.1 |
Components | Android |
Labels | parity, release-note-1.8.0, stage |
Reporter | Marshall Culpepper |
Assignee | Bill Dawson |
Created | 2011-04-15T03:22:59.000+0000 |
Updated | 2011-12-06T15:19:54.000+0000 |
Description
It may not be possible to implement this the way iOS did, but we should at least expose open() as a synonym for play(). The VideoPlayer API in general may need to be reigned in when we work out the layout/view system for 1.5.1. Thoughts?
Steps to Reproduce: 1. Run test 1077 from http://wiki.appcelerator.org/display/tp/UI+Composite+Layout+Behavior+Test+Case Actual step: Run-time error Note: Adding the video player to parent causes a runtime error
Pull request ready https://github.com/appcelerator/titanium_mobile/pull/701
*For release notes* -- Previous default behavior, since we couldn't add the player to a parent view, was that fullscreen would be true. That's not the case for iOS, and for parity's sake it's no longer the case for Android now that we can put the player on a view. So if fullscreen is desired now in Android, you must specifically set fullscreen to true.
Tested with 1.8.0.1.v20111205164258 v8/rhino on Galaxy 10.1 (3.1) Droid 1 (2.2.2) Nexus S (2.3.6)