[TIMOB-25672] iOS: Address 10+ compiler warnings and general issues in source project
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2018-01-23T19:24:49.000+0000 |
Affected Version/s | Release 7.0.0 |
Fix Version/s | Release 7.0.2 |
Components | iOS |
Labels | bug, ios, memoryleak, merge-7.0.2 |
Reporter | Hans Knöchel |
Assignee | Hans Knöchel |
Created | 2018-01-14T15:34:32.000+0000 |
Updated | 2018-01-24T22:14:34.000+0000 |
Description
We currently have a number of (non-critical) warnings in the iOS source, caused by some PR's over the last months. Examples
* Unknown selector-warnings because of text-field changes (selector is in place, but not referenced correctly)
* Unknown selector-warning because of APSAnalytics (a recent updated missed to expose it)
* Deprecating warnings (about AUTHORIZATION_AUTHORIZED which is technically identical to AUTHORIZATION_ALWAYS)
* Missing 1024x1024px launch-screen (development-only, missing since Xcode 9 update)
* Fix memory leaks
* Fix an issue where the VideoPlayer would crash after closing and waiting for deallocation (~ 30s)
* Fix an issue where the thumbnail-generation of the video-player would block the UI
To fix this, it requires two small PR's to aps_sdk and titanium_mobile
PR (aps_sdk/master): https://github.com/appcelerator/aps_sdk/pull/308 PR (titanium_mobile/master): https://github.com/appcelerator/titanium_mobile/pull/9733 PR (titanium_mobile/7_0_X): https://github.com/appcelerator/titanium_mobile/pull/9734
FR passed.
Verified fix is found in: SDK 7.0.2.v20180124113923 SDK 7.1.0.v20180124115505