[TIMOB-25703] Android: Add VideoPlayer "showsControls" property
GitHub Issue | n/a |
---|---|
Type | Improvement |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2018-02-13T20:26:06.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 7.1.0 |
Components | Android |
Labels | android, parity, videoplayer |
Reporter | Joshua Quick |
Assignee | Joshua Quick |
Created | 2018-01-24T21:40:43.000+0000 |
Updated | 2018-03-02T00:11:26.000+0000 |
Description
*Summary:*
As of Titanium 7.0.0, we've added VideoPlayer.showsControls property for iOS to show/hide the overlaid video controls. We should do the same on Android for parity.
http://docs.appcelerator.com/platform/latest/#!/api/Titanium.Media.VideoPlayer-property-showsControls
*Test:*
Once this feature is implemented, run the below code on Android and verify that the video player does not show any overlaid controls when the video is tapped on.
var window = Ti.UI.createWindow({ fullscreen: true });
var videoView = Ti.Media.createVideoPlayer(
{
url: "http://download.blender.org/peach/bigbuckbunny_movies/BigBuckBunny_640x360.m4v",
autoplay: true,
showsControls: false,
scalingMode: Ti.Media.VIDEO_SCALING_ASPECT_FIT,
width: Ti.UI.FILL,
height: Ti.UI.FILL,
});
window.add(videoView);
window.open();
PR (master): https://github.com/appcelerator/titanium_mobile/pull/9770
FR Passed. Waiting for merge to be enabled.
PR Merged.
I've confirmed that this change is in the 7_1_X branch as well.
Verified the fix in SDK 7.1.0.v20180301114750 & 7.2.0.v20180301081409. Closing. Studio Ver: 5.0.0.201712081732 OS Ver: 10.13.2 Xcode Ver: Xcode 9.2 Appc NPM: 4.2.12 Appc CLI: 7.0.2 Daemon Ver: 1.0.1 Ti CLI Ver: 5.0.14 Alloy Ver: 1.11.0 Node Ver: 8.9.1 NPM Ver: 5.5.1 Java Ver: 1.8.0_101 Devices: ⇨ google Nexus 6P — Android 8.0.0 ⇨ google Nexus 5 — Android 6.0.1