[TIMOB-25823] Liveview: Server not stopped when using a custom ip or port
GitHub Issue | n/a |
Type | Bug |
Priority | None |
Status | Open |
Resolution | Unresolved |
Affected Version/s | n/a |
Fix Version/s | n/a |
Components | LiveView |
Labels | n/a |
Reporter | Ewan Harris |
Assignee | Ebenezer Boateng |
Created | 2018-02-28T14:03:39.000+0000 |
Updated | 2020-02-19T10:48:23.000+0000 |
Description
Description
On Windows it is generally necessary to use define a custom IP for liveview to use due to the number of network interfaces that can be defined on a developers machine (docker vethernet, windows mobile emulator vethernet etc.), however when the liveview hook attempts to stop running servers it uses a hardcoded value of http://localhost:8324/kill
, this should be dynamic using the defined port/ip
Steps to reproduce
You need to define a custom port for liveview usage using --liveview-fport 1234
(you can define this in the liveview config section of Studio too if not using the cli)
Build with liveview enabled and a custom port
Build with liveview enabled and a custom port again
Actual
On the second build the log Address in use, retrying...
will repeatedly be shown in the console as the liveview server couldn't be killed
Expected
Liveview server should be killed between runs
Comments
JSON Source
My workaround is to use command: powershell -Command "Stop-Process -Id (Get-NetTCPConnection -LocalPort *liveview-fport*).OwningProcess -Force"