[TIMOB-25914] Windows: ReferenceError: __ is not defined when building a module where the apiversion does not match

GitHub Issue	n/a
Type	Bug
Priority	None
Status	Closed
Resolution	Fixed
Resolution Date	2018-09-17T09:25:47.000+0000
Affected Version/s	Release 7.1.0, Release 7.0.2, Release 7.1.1
Fix Version/s	n/a
Components	Windows
Labels	n/a
Reporter	Ewan Harris
Assignee	Ewan Harris
Created	2018-03-29T14:10:06.000+0000
Updated	2018-09-24T10:26:04.000+0000

Description

When there is an apiversion mismatch between the SDK and a module then the CLI will error with the below

C:\ProgramData\Titanium\mobilesdk\win32\7.1.1.v20180327164201\windows\cli\commands\_buildModule.js:51
                logger.error(__('The module manifest apiversion is currently set to %s', manifest.apiversion));
         ^
ReferenceError: __ is not defined
    at WindowsModuleBuilder.validate (C:\ProgramData\Titanium\mobilesdk\win32\7.1.1.v20180327164201\windows\cli\commands\_buildModule.js:51:10)
    at Object.exports.validatePlatformOptions (C:\ProgramData\Titanium\mobilesdk\win32\7.1.1.v20180327164201\node_modules\node-titanium-sdk\lib\titanium.js:673:69)

Steps to reproduce

1. Create a windows module or download an existing one like ti.paint 2. Change the apiversion in the manifest file 3. Build the module using ti build -p windows --build-only

Actual

Build errors with the above

Expected

Build should not error

Comments

Ewan Harris 2018-03-29

master: https://github.com/appcelerator/titanium_mobile_windows/pull/1217
Josh Longton 2018-09-17

*FR Passed*
Josh Longton 2018-09-24

*Closing ticket* The fix is present in SDK; {noformat} 7.5.0.v20180922081022 {noformat}

JSON Source