Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-25968] Liveview: Write more information to pidfile, such as port and ip data

GitHub Issuen/a
TypeImprovement
PriorityMedium
StatusClosed
ResolutionFixed
Resolution Date2020-06-17T13:23:24.000+0000
Affected Version/sn/a
Fix Version/sRelease 9.1.0
ComponentsLiveView
Labelsn/a
ReporterEwan Harris
AssigneeEbenezer Boateng
Created2018-04-16T09:59:24.000+0000
Updated2020-06-17T13:25:27.000+0000

Description

Description

Currently when liveview writes its pidfile (at ~/.titanium), it only contains the path of the project, we should write more data to this (ip, fport, eport etc.) so that commands like stop/restart can function if the user defines a custom ip or port. It would probably make sense to turn this file into a json object like below
{
    "projectPath": "<path to project>",
    "ip": "127.0.0.1",
    "eport": "1234",
    "fport": "1235",
    "alloy: true,
    "platform": "android"
}

Comments

  1. Ebenezer Boateng 2020-02-25

    https://github.com/appcelerator/liveview/pull/133
  2. Ewan Harris 2020-03-09

    Removing from current sprint as this will only be testable once we update liveview in the SDK, when we do that we can pull this ticket back into the sprint for qe
  3. Samir Mohammed 2020-06-17

    *FR Passed:* when opening the ~/.titanium location able to see the following
       {
       	"projectPath": "/Users/Samir/Desktop/ayuu",
       	"eport": 8323,
       	"fport": 8324,
       	"alloy": false,
       	"platform": "ios"
       }
       
       
    *Test Environment*
       MacOS Catalina: 10.15.5 Beta
       Xcode: 11.4
       Java Version: 1.8.0_131
       Android NDK: 21.1.6273396-beta2
       Node.js: 10.16.3
       ""NPM":"5.0.0","CLI":"8.0.0""
       Andoird Pixel xl 7.1.1 Emulator 
       iphone 8 (13.4 sim)
       
  4. Samir Mohammed 2020-06-17

    Verified in SDK version 9.1.0.v20200615121135

JSON Source