[TIMOB-26032] iOS/Android: Ti.Contacts.getPersonByIdentifier does not exist (Android), parity is incorrect
GitHub Issue | n/a |
---|---|
Type | Bug |
Priority | High |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2018-10-24T23:17:33.000+0000 |
Affected Version/s | Release 7.0.0, Release 7.1.1, Release 7.2.0 |
Fix Version/s | Release 7.5.0 |
Components | Android |
Labels | contacts, parity |
Reporter | Rene Pot |
Assignee | Hans Knöchel |
Created | 2018-05-11T10:31:29.000+0000 |
Updated | 2018-10-25T14:52:35.000+0000 |
Description
According to the docs
getPersonByID
is deprecated for iOS9+ and getPersonByIdentifier
should be used.
Docs also specify this is available for Android starting 5.0, however, this method doesn't exist in the code.
For Parity reasons we should add this method to Android as well.
There is another issue on the iOS side here: The new API is iOS 9 or later, so the dev would need to use two different methods to support iOS 8 as well. I would propose to do some iOS refactoring there and do Android as well.
PR: https://github.com/appcelerator/titanium_mobile/pull/10038 Test-Case: [~topener] Could this please be delivered by the community?
PR Merged.
*Closing ticket* Code changes verified in SDK Version
7.5.0.v20181025051112
. Test and other information can be found at: https://github.com/appcelerator/titanium_mobile/pull/10038