[TIMOB-26055] Android: Build fails due to invalid character '$' in android manifest with facebook & liveview with 7.3.0 SDK

GitHub Issue	n/a
Type	Bug
Priority	Medium
Status	Closed
Resolution	Fixed
Resolution Date	2018-07-25T06:29:29.000+0000
Affected Version/s	n/a
Fix Version/s	Release 7.3.0
Components	Android
Labels	regression
Reporter	Lokesh Choudhary
Assignee	Joshua Quick
Created	2018-05-18T17:22:28.000+0000
Updated	2018-07-25T23:44:51.000+0000

Description

This can be called as a regression. Works with 7.1.1.GA

Steps to reproduce:

1. Create a default app for android. 2. Add the facebook module to the tiapp.xml. 3. Build the app with SDK 7.3.0 (I used 7.3.0.v20180518082133).

Actual result:

1. Build fails to package with error:

[ERROR] :  Failed to package application:
[ERROR] :  
[ERROR] :  (skipping file '.liveviewapp.js' due to ANDROID_AAPT_IGNORE pattern '.*')
[ERROR] :  /Users/lchoudhary/Desktop/workspaces/workspace_2018/zdummy/build/android/AndroidManifest.xml:24: Tag <provider> attribute authorities has invalid character '$'.
[ERROR] Application Installer abnormal process termination. Process exit value was 1

2. In the android manifest this line gets added:

<provider android:name="com.facebook.internal.FacebookInitProvider" android:authorities="${applicationId}.FacebookInitProvider" android:exported="false"/>

3. Build fails due to the $ symbol. Expected result: 1. Build should not fail when facebook & liveview are used in the app.

Comments

Gary Mathews 2018-05-18

master: https://github.com/appcelerator/titanium_mobile/pull/10065
Lokesh Choudhary 2018-05-18

FR Passed. PR Merged.
Lokesh Choudhary 2018-06-18

Verified the fix in SDK 7.3.0.v20180618062809. Closing.
Joshua Quick 2018-07-24

This isn't completely fixed yet. A build error will occur if you include the "titanium-firebase-core" module version 2.1.0 or higher here... https://github.com/hansemannn/titanium-firebase-core _*Edit:*_ _Gary had the right solution. It just needed to do a replace-all instead of a single replace, which is what he meant to do._
Joshua Quick 2018-07-24

PR (master): https://github.com/appcelerator/titanium_mobile/pull/10206 PR (7.3.0): https://github.com/appcelerator/titanium_mobile/pull/10207
Lokesh Choudhary 2018-07-25

Verified the fix in SDK 7.3.0.v20180724235918 & 7.4.0.v20180725161202. Closing.

JSON Source