[TIMOB-26111] iOS: Fix static analyzer warnings and possible leaks
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2018-06-13T14:38:46.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 7.5.0 |
| Components | iOS |
| Labels | n/a |
| Reporter | Hans Knöchel |
| Assignee | Hans Knöchel |
| Created | 2018-06-08T00:31:42.000+0000 |
| Updated | 2018-10-03T11:12:27.000+0000 |
Description
The new static analyzer in Xcode 10 surfaces a few issues that we haven't been aware so far. These should be addressed and unit-tested with the existing test-suite
PR: https://github.com/appcelerator/titanium_mobile/pull/10098/files Test-Cases: Via existing unit-tests. The calendar one cannot be unit-tested, since it requires UI-interaction, but it's also pretty save as per standard alloc/release rules.
*Closing ticket.* Tested on SDK Version
7.5.0.v20180928103802. Improvement can be seen on the amount of static analyzer warnings and possible leaks, (Although the improvement was little). Tested using a calendar module test, a userActivity test that includes the continueUserActivity event, and notifications with attachments. The amount of analyzer warnings and possible leaks were then compared against 7.4.1. *Test Environment*