[TIMOB-26155] Android: ListView setItems causes error after updateItemAt used with custom template
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | Critical |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2018-07-03T16:38:30.000+0000 |
| Affected Version/s | Release 7.2.0 |
| Fix Version/s | Release 7.5.0 |
| Components | Android |
| Labels | defect |
| Reporter | Russell Kenny |
| Assignee | Gary Mathews |
| Created | 2018-06-22T20:24:20.000+0000 |
| Updated | 2018-09-20T14:11:29.000+0000 |
Description
I am attempting to use ListView to hold a series of Switch + Labels for a question and answer app. When the user selects one answer (either by clicking the switch or clicking the label), I am setting all other Switches to false so that only one answer can be selected.
Below is the minimum code to reproduce the issue. What you will see is if the user does not click any Switches / Labels and just clicks the button, the first set of answers is replaced by the second set of answers without any issue. If the user clicks a Switch / Label, which causes updateItemAt() to be used on each row, then when the button is pressed to replace the answers shown, an error occurs.
----
<Alloy>
<Window id="questWin" title="Questions and Answers">
<View layout="horizontal">
<ListView top="0" left="24dp" width="Ti.UI.FILL" height="Ti.UI.SIZE" id="answerList" defaultItemTemplate="answerTmpl" separatorColor="#BBB" onItemclick="clickAns">
<Templates>
<ItemTemplate top="8dp" bottom="8dp" width="Ti.UI.FILL" height="Ti.UI.SIZE" name="answerTmpl">
<View top="0" left="0" layout="horizontal" width="Ti.UI.FILL" height="Ti.UI.SIZE">
<Switch left="0" width="Ti.UI.SIZE" height="Ti.UI.SIZE" style="Titanium.UI.Android.SWITCH_STYLE_CHECKBOX" bindId="ansCheck" />
<Label left="8dp" width="Ti.UI.FILL" height="Ti.UI.SIZE" bindId="ansLabel" />
</View>
</ItemTemplate>
</Templates>
<ListSection id="answerSec" />
</ListView>
<Button top="12dp" width="160dp" onClick="clickSubmitBtn">Submit</Button>
</View>
</Window>
</Alloy>
// Arguments passed into this controller can be accessed via the $.args object directly or:
var args = $.args;
var giSelAns = null;
function clickAns(e) {
giSelAns = e.itemIndex;
for (var iCnt = 0; iCnt < $.answerSec.items.length; iCnt++) {
var item = $.answerSec.getItemAt(iCnt);
if (iCnt == giSelAns)
item.ansCheck.value = true;
else
item.ansCheck.value = false;
$.answerSec.updateItemAt(iCnt, item);
}
}
function clickSubmitBtn() {
// Skipping code to check correct, answer, etc.
answers = [
{ ansLabel: { text: "Second Answer 1" }, ansCheck: { isCorrect: false } },
{ ansLabel: { text: "Second Answer 2" }, ansCheck: { isCorrect: true } },
{ ansLabel: { text: "Second Answer 3" }, ansCheck: { isCorrect: false } },
];
$.answerSec.setItems(answers);
}
$.questWin.addEventListener("open", function() {
answers = [
{ ansLabel: { text: "First Answer 1" }, ansCheck: { isCorrect: true } },
{ ansLabel: { text: "First Answer 2" }, ansCheck: { isCorrect: false } },
{ ansLabel: { text: "First Answer 3" }, ansCheck: { isCorrect: false } },
];
$.answerSec.setItems(answers);
});
$.questWin.addEventListener("close", function(){
$.destroy();
});
$.questWin.open();
master: https://github.com/appcelerator/titanium_mobile/pull/10148
[~gmathews] Using SDK version
7.4.0.v20180718223310and the test case provided in the description. I get an application crash (no error shown in the console) when choosing an answer and then pressing submit. *Test Environment**Closing ticket.* On the latest SDK
7.5.0.v20180920040518the application no longer crashes when clicking on an answer and then pressing submit. *Test Environment* APPC Studio: 5.1.0.201808080937 APPC CLI: 7.0.7-master.1 Nexus 6P (API 23) Operating System Name: Mac OS High Sierra Operating System Version: 10.13.6 Node.js Version: 8.9.1