[TIMOB-26201] TiAPI: Remove all deprecated API's (<= SDK 7.0)
GitHub Issue | n/a |
---|---|
Type | Story |
Priority | Medium |
Status | Closed |
Resolution | Fixed |
Resolution Date | 2019-12-16T19:34:43.000+0000 |
Affected Version/s | n/a |
Fix Version/s | Release 9.0.0 |
Components | Android, iOS |
Labels | n/a |
Reporter | Yordan Banev |
Assignee | Christopher Williams |
Created | 2018-07-11T14:11:25.000+0000 |
Updated | 2020-02-12T15:13:53.000+0000 |
Description
There are many API's (321 in total) that are currently deprecated in the SDK. All API's that have been deprecated before 5.x (e.g. 3.2, 4.0 etc) should go away these days. Some major examples:
- Titanium.Android.Calendar -> Ti.Calendar (since 3.2.0)
- PENDING_INTENT_FOR_* (since 2.0.0)
- Android geolocation legacy mode (since 2.0.0)
- Ti.Network.SOCKET_* (since 1.7.0)
We could likely save a good amount of compile time for both docs-gen and the SDK itself by removing this.
(Edit by Hans: Renamed the ticket to handle all deprecations, not just Ti.Calendar.Event).
[~cwilliams] Are you okay with removing them all together? Any design thoughts on the upper limit of removal? Everything < SDK 5.0? Or <= SDK 5.0?
Apologies for butting in, but I think we're fine to remove anything that's been deprecated since before the last major (so 7.0 for 8.0) based off https://docs.appcelerator.com/platform/latest/#!/guide/Axway_Appcelerator_Deprecation_Policy ?
If everyone agrees on that, sure! I'd love to rip it all out.
Ready for review. [~kiguchi] Do we have Windows API's that have been deprecated in <= 7.0.0? Then we should clone this for Windows and clean up there as well.
Thanks for heads up, created TIMOB-26236 to track this for Windows.
This was kind of an ongoing effort across multiple PRs: - https://github.com/appcelerator/titanium_mobile/pull/11368 - https://github.com/appcelerator/titanium_mobile/pull/11386 - https://github.com/appcelerator/titanium_mobile/pull/11362 The individual PRs list the removals and updated the docs. I likely will not get absolutely every pre-7.0.0 API done in time for 9.0.0 release. But I've whittled it down considerably.
Note also that I created a package.json script to report the APIs that have been long-deprecated but not yet marked removed: https://github.com/appcelerator/titanium_mobile/pull/11366 So gathering the future listings of what to double-check and remove should be easier.
Closing ticket, verified code changes in SDK version 9.0.0.v20200211122336.