[TIMOB-26241] Hyperloop: iOS - Build error because of duplicate builtins in 3.1.0

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Resolved
Resolution	Fixed
Resolution Date	2018-07-27T14:34:33.000+0000
Affected Version/s	Hyperloop 3.1.0
Fix Version/s	Hyperloop 3.1.1
Components	iOS
Labels	n/a
Reporter	Hans Knöchel
Assignee	Hans Knöchel
Created	2018-07-27T11:06:21.000+0000
Updated	2018-07-27T14:34:33.000+0000

Description

When using Hyperloop 3.1.0, the following build error occurs on the hyperloop-examples app:


/Users/hknoechel/Documents/Apps/hyperloop-examples/modules/iphone/hyperloop/3.1.0/hooks/generate/util.js:308
			if (isPrimitive(type) || value.indexOf('*') > 0) {
                                  ^
TypeError: Cannot read property 'indexOf' of undefined
    at getResultWrapper (/Users/hknoechel/Documents/Apps/hyperloop-examples/modules/iphone/hyperloop/3.1.0/hooks/generate/util.js:308:35)
    at generatePropGetter (/Users/hknoechel/Documents/Apps/hyperloop-examples/modules/iphone/hyperloop/3.1.0/hooks/generate/util.js:631:16)
    at Object.generateProp (/Users/hknoechel/Documents/Apps/hyperloop-examples/modules/iphone/hyperloop/3.1.0/hooks/generate/util.js:655:18)
    at /Users/hknoechel/Documents/Apps/hyperloop-examples/modules/iphone/hyperloop/3.1.0/hooks/generate/class.js:36:16
    at Array.forEach (<anonymous>)
    at makeClass (/Users/hknoechel/Documents/Apps/hyperloop-examples/modules/iphone/hyperloop/3.1.0/hooks/generate/class.js:26:55)
    at Object.generate (/Users/hknoechel/Documents/Apps/hyperloop-examples/modules/iphone/hyperloop/3.1.0/hooks/generate/class.js:132:9)
    at /Users/hknoechel/Documents/Apps/hyperloop-examples/modules/iphone/hyperloop/3.1.0/hooks/generate/index.js:244:36
    at Array.forEach (<anonymous>)
    at /Users/hknoechel/Documents/Apps/hyperloop-examples/modules/iphone/hyperloop/3.1.0/hooks/generate/index.js:224:29

This does not happen with 3.0.5

Comments

Hans Knöchel 2018-07-27

The cause was a duplicated entry of the userAgent property that is part of our TiApp builtin. PR (master): https://github.com/appcelerator/hyperloop.next/pull/295 PR (3_1_X): https://github.com/appcelerator/hyperloop.next/pull/296

JSON Source