[TIMOB-26345] iOS CLI: Upload to AppStore fails if app contains non-alphanumeric characters

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2018-08-31T15:08:00.000+0000
Affected Version/s	n/a
Fix Version/s	Release 7.5.0
Components	CLI, iOS
Labels	appstore, cli, ios
Reporter	Hans Knöchel
Assignee	Hans Knöchel
Created	2018-08-31T12:06:05.000+0000
Updated	2018-09-10T19:24:41.000+0000

Description

There is an issue when uploading iOS apps to the AppStore if these contains special characters. In my test-case, it was "Test!123". The underlaying issue is that we generated url schemes for the app that are not escaped. Example:

	<key>CFBundleURLTypes</key>
	<array>
		<dict>
			<key>CFBundleURLName</key>
			<string>com.appc.test</string>
			<key>CFBundleURLSchemes</key>
			<array>
				<string>test!123</string>
			</array>
		</dict>
	</array>

A simple fix is to escape the url scheme during build and be good to go. In a later major release, we could also evaluate not generating the url scheme at all, since it should be up to the developer to configure that.

Comments

Hans Knöchel 2018-08-31

PR: https://github.com/appcelerator/titanium_mobile/pull/10299 Test-Case: 1. Create a new app with the name "Test!123" 2. Build for production 3. Inspect the build/iphone/Info.plist for it's URL schemes Expected result: "test123", not "test!123".

Keerthi Mahalingam 2018-09-10

Verified the fix on sdk 7.5.0.v20180906093938. Successfully uploaded app to appstore and verified the URL scheme on info.plist as test123. Closing.

   Operating System
     Name                        = Mac OS X
     Version                     = 10.13.6
    Node.js
     Node.js Version             = 8.9.1
     npm Version                 = 5.5.1
   Titanium CLI
     CLI Version                 = 5.1.1
   Titanium SDK
     SDK Version                 = 7.5.0.v20180906093938
   IPhone 6s with ios 12

JSON Source