Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-26354] Android: Refactor TabGroup and introduce new style

GitHub Issuen/a
TypeNew Feature
PriorityLow
StatusClosed
ResolutionFixed
Resolution Date2018-12-11T17:43:58.000+0000
Affected Version/sn/a
Fix Version/sRelease 8.0.0
ComponentsAndroid
LabelsTabGroup, android, material-design
ReporterYordan Banev
AssigneeYordan Banev
Created2018-09-05T08:03:12.000+0000
Updated2020-03-11T02:45:00.000+0000

Description

Attachments

FileDateSize
Screen Shot 2018-10-19 at 10.00.02 AM.png2018-10-19T17:00:19.000+0000169586

Comments

  1. Yordan Banev 2018-10-17

    PR: https://github.com/appcelerator/titanium_mobile/pull/10358
  2. Lokesh Choudhary 2018-10-18

    Found issues commented in PR.
  3. Yordan Banev 2018-10-19

    I can't reproduce it on a Pixel emulator with Android 4.1. Can you share details about the device/emulator you had the crash on?
  4. Lokesh Choudhary 2018-10-19

    [~ybanev], I am using Nexus 4 Android 4.1 emulator. !Screen Shot 2018-10-19 at 10.00.02 AM.png|thumbnail!
  5. Lokesh Choudhary 2018-10-22

    FR Passed. Waiting for CR .
  6. Lokesh Choudhary 2018-12-11

    PR Merged.
  7. Samir Mohammed 2018-12-12

  8. Ygor Lemos 2019-01-16

    Hi guys, is it possible for this to be back-ported / merged on 7.5.X? Thanks!
  9. Joshua Quick 2019-01-16

    [~ygbr], no. It won't be back-ported. The TabGroup code has been completely re-written and is a bit of breaking-change since it no longer depends on the ActionBar. On the plus side, you can now globally use a "NoTitleBar" theme since the ActionBar is no longer required. On the minus side, the tab bar is no longer embedded within the ActionBar when landscape and always appears below it, eating up vertical space. Breaking-changes like this belong in major revisions of Titanium for app developer to opt-in to.

JSON Source