[TIMOB-26354] Android: Refactor TabGroup and introduce new style
| GitHub Issue | n/a |
|---|---|
| Type | New Feature |
| Priority | Low |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2018-12-11T17:43:58.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 8.0.0 |
| Components | Android |
| Labels | TabGroup, android, material-design |
| Reporter | Yordan Banev |
| Assignee | Yordan Banev |
| Created | 2018-09-05T08:03:12.000+0000 |
| Updated | 2020-03-11T02:45:00.000+0000 |
Description
Attachments
| File | Date | Size |
|---|---|---|
| Screen Shot 2018-10-19 at 10.00.02 AM.png | 2018-10-19T17:00:19.000+0000 | 169586 |
PR: https://github.com/appcelerator/titanium_mobile/pull/10358
Found issues commented in PR.
I can't reproduce it on a Pixel emulator with Android 4.1. Can you share details about the device/emulator you had the crash on?
[~ybanev], I am using Nexus 4 Android 4.1 emulator. !Screen Shot 2018-10-19 at 10.00.02 AM.png|thumbnail!
FR Passed. Waiting for CR .
PR Merged.
Hi guys, is it possible for this to be back-ported / merged on 7.5.X? Thanks!
[~ygbr], no. It won't be back-ported. The
TabGroupcode has been completely re-written and is a bit of breaking-change since it no longer depends on theActionBar. On the plus side, you can now globally use a "NoTitleBar" theme since theActionBaris no longer required. On the minus side, the tab bar is no longer embedded within theActionBarwhen landscape and always appears below it, eating up vertical space. Breaking-changes like this belong in major revisions of Titanium for app developer to opt-in to.