[TIMOB-26388] iOS 12: Support iPhone Xs Max & iPhone XR launch-screen images
| GitHub Issue | n/a |
|---|---|
| Type | Bug |
| Priority | None |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2018-09-13T18:37:16.000+0000 |
| Affected Version/s | n/a |
| Fix Version/s | Release 7.4.0 |
| Components | iOS |
| Labels | n/a |
| Reporter | Hans Knöchel |
| Assignee | Hans Knöchel |
| Created | 2018-09-13T06:09:33.000+0000 |
| Updated | 2018-09-17T12:47:31.000+0000 |
Description
Pretty much the same as TIMOB-25269, but now for another device. We need to figure out the names for the iPhone Xs launch-screen image names and handle those for the launch-screen image. This is required to incorporate the new image dimensions (and notch changes) that the new model includes.
*Important note: This can be easily workarounded by using launch-screen storyboards as documented [here](https://wiki.appcelerator.org/display/guides2/iOS+Launch+Files).
PR (titanium_mobile/master): https://github.com/appcelerator/titanium_mobile/pull/10321 PR (titanium_mobile/7_4_X): https://github.com/appcelerator/titanium_mobile/pull/10322 PR (alloy/master): https://github.com/appcelerator/alloy/pull/908
Is there a PR for the "next" branch?
Merged to master/7_4_X. [~cbarber] I merge master branch into next occasionally to keep them in sync. I can merge again since this has been merged.
Verified and included in SDK builds: 7.4.0.v20180913113957 & 7.5.0.v20180917031523 Able to build and run projects for the new simulators (iPhone XS, XS Max, and XR) as well as older, existing simulators. Projects displayed within the correct boundaries.