[TIMOB-26479] TiUtils.m missing check for iPhone XR and iPhone XS Max images

GitHub Issue	n/a
Type	Bug
Priority	Critical
Status	Closed
Resolution	Fixed
Resolution Date	2018-11-01T09:40:51.000+0000
Affected Version/s	n/a
Fix Version/s	Release 7.5.0
Components	iOS
Labels	iPhoneXr, iPhoneXsMax
Reporter	Thomas Neerup
Assignee	Vijay Singh
Created	2018-10-18T13:23:12.000+0000
Updated	2018-11-01T09:41:03.000+0000

Description

TiUtils.m missing check for iPhone XR and iPhone XS Max images So these devices will display the image@x2.png/jpg instead of image-2688@3x.png/jpg image-1792@2x.png/jpg

Attachments

File	Date	Size
images.zip	2018-10-23T08:51:47.000+0000	1641449

Comments

Ewan Harris 2018-10-18

[~thomas.neerup@eg.dk] Can you please note the SDK your seeing this with?
Thomas Neerup 2018-10-18

7.4.0
Vijay Singh 2018-10-19
Thomas Neerup 2018-10-19
Thomas Neerup 2018-10-23

I reported TIMOB-25504 last time a new iPhone size was introduced, seems like this is the same problem all over again... Please put some love into this one
Vijay Singh 2018-10-23

[~thomas.neerup@eg.dk] Thanks for reporting. I have created PR for same. https://github.com/appcelerator/titanium_mobile/pull/10392

Vijay Singh 2018-10-23

Test Case -

   var win = Ti.UI.createWindow({
       backgroundImage: '/images/index.jpg'
   });
   
   var btn = Ti.UI.createButton({
       title: 'Trigger'
   });
   
   btn.addEventListener('click', function() {
       Ti.API.info('Hello world!');
   });
   
   win.add(btn);
   win.open();

Thomas Neerup 2018-10-23

Release 8.0.0 !!!! this is just sad... 2 min fix can't make it into the next bugfix...
Thomas Neerup 2018-10-24

Thank you very much
Samir Mohammed 2018-10-30

Using an Alloy application iPhone XR shows a blank image
Vijay Singh 2018-10-31

[~smohammed] Please check with false in tiapp.xml. Thanks!
Samir Mohammed 2018-10-31

[~vijaysingh] When adding the following in to the Tiapp.xml <use-app-thinning>false</use-app-thinning> The correct images seems to be shown on the correct simulators.
Samir Mohammed 2018-11-01

*Closing ticket* Fix verified in SDK Version 7.5.0.v20181003071100 able to see the correct images on the specified device.

JSON Source