[TIMOB-26503] Windows: Touch event coordinate units do not match between platforms
| GitHub Issue | n/a |
|---|---|
| Type | Improvement |
| Priority | High |
| Status | Closed |
| Resolution | Fixed |
| Resolution Date | 2018-12-03T09:53:56.000+0000 |
| Affected Version/s | Release 6.0.0 |
| Fix Version/s | Release 8.0.0 |
| Components | Windows |
| Labels | breaking-change, parity |
| Reporter | Joshua Quick |
| Assignee | Kota Iguchi |
| Created | 2018-10-31T02:25:59.000+0000 |
| Updated | 2018-12-03T12:10:11.000+0000 |
Description
*Summary:*
The (x,y) units provided by View event's "touchstart", "touchmove", "touchend", and "touchcancel" do not match between Android and iOS. Both platforms ignore the "ti.ui.defaultunit" property setting in "tiapp.xml".
On Android, the touch coordinates are always in "px" (ie: pixels).
On iOS, the touch coordinates are always in "dip" (aka: "dp").
*Steps to Reproduce:*
Build and run the below code on Android.
Drag your finger in the gray view.
Notice that the blue square does *not* correctly following your finger.
Build and run on iOS.
Drag your finger in the gray view.
Notice that the blue square *correctly* follows your finger.
Change "tiapp.xml" property "ti.ui.defaultunit" to "px".
Build and run on iOS.
Drag your finger in the gray view.
Notice that the blue square does *not* correctly following your finger.
Build and run on Android.
Drag your finger in the gray view.
Notice that the blue square *correctly* follows your finger.
function onTouch(event) {
touchView.center = { x: event.x, y: event.y };
}
var window = Ti.UI.createWindow(
{
layout: "vertical",
fullscreen: true,
});
window.add(Ti.UI.createLabel(
{
text: "Touch Drag Test",
top: "20dp",
}));
var containerView = Ti.UI.createView(
{
touchEnabled: true,
backgroundColor: "gray",
top: "10dp",
bottom: "20dp",
width: "90%",
});
var touchView = Ti.UI.createView(
{
touchEnabled: false,
backgroundColor: "#008800",
width: "100dp",
height: "100dp",
});
containerView.add(touchView);
containerView.addEventListener("touchstart", onTouch);
containerView.addEventListener("touchmove", onTouch);
containerView.addEventListener("touchend", onTouch);
containerView.addEventListener("touchcancel", onTouch);
window.add(containerView);
window.open();
// Fetch the default unit property set in "tiapp.xml".
var defaultUnit = Ti.App.Properties.getString("ti.ui.defaultunit", "dip");
if (defaultUnit === "dp") {
defaultUnit = "dip";
} else if (defaultUnit === "system") {
defaultUnit = (Ti.Platform.name === "android") ? "px" : "dip";
}
// Do the below when a touch event has been received.
function onTouch(event) {
if (Ti.Platform.name === "android") {
event.x = Ti.UI.convertUnits(event.x + "px", defaultUnit);
event.y = Ti.UI.convertUnits(event.y + "px", defaultUnit);
} else if ((Ti.Platform.name === "iOS") || (Ti.Platform.name === "iPhone OS")) {
event.x = Ti.UI.convertUnits(event.x + "dip", defaultUnit);
event.y = Ti.UI.convertUnits(event.y + "dip", defaultUnit);
}
touchView.center = { x: event.x, y: event.y };
}
https://github.com/appcelerator/titanium_mobile_windows/pull/1301
FR Passed, awaiting CR.
Closing ticket. Verified feature in SDK version 8.0.0.v20181130132038. Test and other information can be found at: https://github.com/appcelerator/titanium_mobile_windows/pull/1301