[TIMOB-26537] Android: Module "AndroidManifest.xml" <uses> elements overwrites "tiapp.xml" elements

GitHub Issue	n/a
Type	Bug
Priority	High
Status	Closed
Resolution	Fixed
Resolution Date	2018-12-27T19:49:57.000+0000
Affected Version/s	n/a
Fix Version/s	Release 8.0.0
Components	Android
Labels	android, build, cli, manifest, module
Reporter	Motiur Rahman
Assignee	Yordan Banev
Created	2016-06-01T21:42:16.000+0000
Updated	2019-01-15T17:58:17.000+0000

Description

Attachments

File	Date	Size
with_Map_Module_AndroidManifest.txt	2016-06-01T21:42:03.000+0000	2432
Without_Map_Mdule_AndroidManifest.txt	2016-06-01T21:39:54.000+0000	2073

Comments

Ricardo Ramirez 2016-10-18

updates ?
Michael Gangolf 2018-09-06

I found the problem: https://github.com/appcelerator/titanium_mobile/blob/master/android/cli/lib/AndroidManifest.js#L493 This loop will run multiple times (for each module) and adds the uses-features. If you have two uses-features in your tiapp.xml the output in the first run will be {noformat} tag: uses-feature, name: 0 { name: 'android.hardware.camera', required: false } tag: uses-feature, name: 1 { name: 'android.hardware.camera.focus', required: false } {noformat} Then when it adds the ti.map uses-features the first output is: {noformat} tag: uses-feature, name: 0 { glEsVersion: '0x00020000', required: true } {noformat} so this will overwrite the first item! Changing it to {noformat} this[tag][src[tag][name]] = src[tag][name]; {noformat} would fix the missing items but it will fail for elements that don't have a name like {noformat}{noformat} They will appear multiple times in the output.
Hans Knöchel 2018-11-11

This is currently an Android P blocker and should definitely be fixed before 7.5.0 is released. Without this fix, no devices running Android P will be able to run apps that use Ti.Map because of MOD-2467. The (really bad) workaround we used for now is to inject it to the SDK manually, by copying the required <uses-feature> flag into: ~/Library/Application Support/Titanium/mobilesdk/osx/7.4.1.GA/android/templates/build/AndroidManifest.xml Replace with the version you are using of course.
Yordan Banev 2018-11-14

PR: https://github.com/appcelerator/titanium_mobile/pull/10467
Lokesh Choudhary 2018-12-27

FR Passed. PR Merged.
Samir Mohammed 2019-01-03

Closing ticket. Fix verified in SDK version 8.0.0.v20190102142454 Test and other information can be found at: https://github.com/appcelerator/titanium_mobile/pull/10467

Hans Knöchel 2019-01-15

This is NOT fixed. We just pulled down a fresh 8_0_X and still seeing the error described in MOD-2467.

   [ERROR] TiExceptionHandler: (main) [829,35362] Failed resolution of: Lorg/apache/http/ProtocolVersion;
   [ERROR] TiExceptionHandler:
   [ERROR] TiExceptionHandler:     dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:134)
   [ERROR] TiExceptionHandler:     java.lang.ClassLoader.loadClass(ClassLoader.java:379)
   [ERROR] TiExceptionHandler:     dhd.loadClass(:com.google.android.gms@12862026@12.8.62 (040700-199405334):3)
   [ERROR] TiExceptionHandler:     java.lang.ClassLoader.loadClass(ClassLoader.java:312)
   [ERROR] TiExceptionHandler:     el.b(:com.google.android.gms.dynamite_mapsdynamite@12862026@12.8.62 (040700-199405334):3)
   [ERROR] TiExceptionHandler:     ek.a(:com.google.android.gms.dynamite_mapsdynamite@12862026@12.8.62 (040700-199405334):4)
   [ERROR] TiExceptionHandler:     em.a(:com.google.android.gms.dynamite_mapsdynamite@12862026@12.8.62 (040700-199405334):51)
   [ERROR] TiExceptionHandler:     com.google.maps.api.android.lib6.drd.ap.a(:com.google.android.gms.dynamite_mapsdynamite@12862026@12.8.62 (040700-199405334):11)
   [ERROR] TiExceptionHandler:     dw.a(:com.google.android.gms.dynamite_mapsdynamite@12862026@12.8.62 (040700-199405334):16)
   [ERROR] TiExceptionHandler:     dw.run(:com.google.android.gms.dynamite_mapsdynamite@12862026@12.8.62 (040700-199405334):61)

Hans Knöchel 2019-01-15

Excuse me, the tag was misplaced! It seems to work fine now.

JSON Source