Titanium JIRA Archive
Titanium SDK/CLI (TIMOB)

[TIMOB-26548] Android: Unable to specify x86 as an abi in tiapp for production builds

GitHub Issuen/a
TypeBug
PriorityNone
StatusClosed
ResolutionFixed
Resolution Date2018-11-13T22:56:01.000+0000
Affected Version/sRelease 8.0.0, Release 7.4.0, Release 7.5.0
Fix Version/sRelease 7.5.0
ComponentsAndroid
Labelsregression
ReporterEwan Harris
AssigneeEwan Harris
Created2018-11-12T15:25:08.000+0000
Updated2018-11-14T00:49:48.000+0000

Description

Description

As raised in AC-5980, it's not possible to specify x86 as an abi to produce during a production build. The build errors with the below. This is because of bad logic [here](https://github.com/appcelerator/titanium_mobile/blob/7_4_X/android/cli/commands/_build.js#L1270) where we always remove x86 from production builds. We should allow users to use it if they want.
[ERROR] Invalid ABI "x86"

Valid ABIs:
   arm64-v8a
   armeabi-v7a

Steps to reproduce

1. Add the below to the android section of your tiapp
	<abi>armeabi-v7a,arm64-v8a,x86</abi>
2. Build for dist-playstore

Actual

Build errors with the above

Expected

Build should not error, x86 should be allowed if a user wants it

Comments

  1. Ewan Harris 2018-11-12

    PR: https://github.com/appcelerator/titanium_mobile/pull/10458
  2. Ewan Harris 2018-11-13

    7_5_X PR: https://github.com/appcelerator/titanium_mobile/pull/10460
  3. Lokesh Choudhary 2018-11-13

    FR Passed. PR's merged.
  4. Lokesh Choudhary 2018-11-14

    Verified the fix in SDK 8.0.0.v20181113150129 & 7.5.0.v20181113143835. Closing.

JSON Source